boost(banner): Always have the latest banner at the top of the stack

Better user experience this way and easier to manage

Author: Belphemur

SoundSwitch/Framework/Banner/BannerForm.cs

@@ -78,15 +78,13 @@ public BannerForm()
         /// Called internally to configure pass notification parameters
         /// </summary>
         /// <param name="data">The configuration data to setup the notification UI</param>
-        /// <param name="positionOffset"></param>
-        internal void SetData(BannerData data, int positionOffset)
+        internal void SetData(BannerData data)
         {
             if (_currentData != null && _currentData.Priority > data.Priority)
             {
                 return;
             }
 
-            _currentOffset = positionOffset;
             _currentData = data;
             if (_timerHide == null)
             {
@@ -116,7 +114,7 @@ internal void SetData(BannerData data, int positionOffset)
 
             var screen = GetScreen();
 
-            Location = data.Position.GetScreenPosition(screen, Height, Width, positionOffset);
+            Location = data.Position.GetScreenPosition(screen, Height, Width, _currentOffset);
 
             _timerHide.Enabled = true;
 
@@ -130,7 +128,7 @@ internal void SetData(BannerData data, int positionOffset)
         public void UpdateLocation(int positionChange)
         {
             var screen = GetScreen();
-            _currentOffset -= positionChange;
+            _currentOffset += positionChange;
             Location = _currentData.Position.GetScreenPosition(screen, Height, Width, _currentOffset);
         }
 

SoundSwitch/Framework/Banner/BannerManager.cs

@@ -24,8 +24,8 @@ namespace SoundSwitch.Framework.Banner
     public class BannerManager
     {
         private static System.Threading.SynchronizationContext _syncContext;
-        private int _currentOffset = 0;
         private readonly Dictionary<Guid, BannerForm> _bannerForms = new();
+        private const int SPACING = 10;
 
         /// <summary>
         /// Show a banner notification with the given data
@@ -39,15 +39,13 @@ public void ShowNotification(BannerData data)
                 var banner = new BannerForm();
                 banner.Disposed += (s, e) =>
                 {
-                    _currentOffset -= banner.Height;
                     _bannerForms.Remove(banner.Id);
-                    foreach (var bannerForm in _bannerForms.Values)
-                    {
-                        bannerForm.UpdateLocation(banner.Height);
-                    }
                 };
-                banner.SetData(data, _currentOffset);
-                _currentOffset += banner.Height;
+                banner.SetData(data);
+                foreach (var bannerForm in _bannerForms.Values)
+                {
+                    bannerForm.UpdateLocation(banner.Height + SPACING);
+                }
                 _bannerForms.Add(banner.Id, banner);
             }, null);
         }