fix(AudioSwitcher::Windows11): Fix possible crash when using profile with application on Windows 11

Author: Belphemur

SoundSwitch.Audio.Manager/AudioSwitcher.cs

@@ -179,7 +179,7 @@ public bool IsDefault(string deviceId, EDataFlow flow, ERole role)
         /// <param name="role"></param>
         /// <param name="processId"></param>
         /// <returns></returns>
-        public string GetUsedDevice(EDataFlow flow, ERole role, uint processId)
+        public string? GetUsedDevice(EDataFlow flow, ERole role, uint processId)
         {
             return ComThread.Invoke(() => ExtendPolicyClient.GetDefaultEndPoint(flow, role, processId));
         }

SoundSwitch.Audio.Manager/Interop/Client/Extended/Post21H2AudioPolicyConfig.cs

@@ -22,19 +22,37 @@ public Post21H2AudioPolicyConfig()
     public void SetPersistedDefaultAudioEndpoint(uint processId, EDataFlow flow, ERole role, string deviceId)
     {
         using var deviceIdHString = HSTRING.FromString(deviceId);
-        Marshal.ThrowExceptionForHR((int)_factory.SetPersistedDefaultAudioEndpoint(processId, flow, role, deviceIdHString));
+        var result = _factory.SetPersistedDefaultAudioEndpoint(processId, flow, role, deviceIdHString);
+        if (result != HRESULT.S_OK && result != HRESULT.PROCESS_NO_AUDIO)
+        {
+            throw new InvalidComObjectException($"Can't set the persistent audio endpoint: {result}");
+        }
     }
 
     public string GetPersistedDefaultAudioEndpoint(uint processId, EDataFlow flow, ERole role)
     {
-        _factory.GetPersistedDefaultAudioEndpoint(processId, flow, role, out var deviceId);
+        var result = _factory.GetPersistedDefaultAudioEndpoint(processId, flow, role, out var deviceId);
+        if (result != HRESULT.S_OK)
+        {
+            if (result != HRESULT.PROCESS_NO_AUDIO)
+            {
+                throw new InvalidComObjectException($"Can't set the persistent audio endpoint: {result}");
+            }
+
+            return null;
+        }
+
         var deviceIdStr = deviceId.ToString();
         deviceId.Dispose();
         return deviceIdStr;
     }
 
     public void ClearAllPersistedApplicationDefaultEndpoints()
     {
-        Marshal.ThrowExceptionForHR((int)_factory.ClearAllPersistedApplicationDefaultEndpoints());
+        var result = _factory.ClearAllPersistedApplicationDefaultEndpoints();
+        if (result != HRESULT.S_OK && result != HRESULT.PROCESS_NO_AUDIO)
+        {
+            throw new InvalidComObjectException($"Reset audio endpoints: {result}");
+        }
     }
 }

SoundSwitch.Audio.Manager/Interop/Client/Extended/Pre21H2AudioPolicyConfig.cs

@@ -22,19 +22,37 @@ public Pre21H2AudioPolicyConfig()
     public void SetPersistedDefaultAudioEndpoint(uint processId, EDataFlow flow, ERole role, string deviceId)
     {
         using var deviceIdHString = HSTRING.FromString(deviceId);
-        Marshal.ThrowExceptionForHR((int)_factory.SetPersistedDefaultAudioEndpoint(processId, flow, role, deviceIdHString));
+        var result = _factory.SetPersistedDefaultAudioEndpoint(processId, flow, role, deviceIdHString);
+        if (result != HRESULT.S_OK && result != HRESULT.PROCESS_NO_AUDIO)
+        {
+            throw new InvalidComObjectException($"Can't set the persistent audio endpoint: {result}");
+        }
     }
 
     public string GetPersistedDefaultAudioEndpoint(uint processId, EDataFlow flow, ERole role)
     {
-        _factory.GetPersistedDefaultAudioEndpoint(processId, flow, role, out var deviceId);
+        var result = _factory.GetPersistedDefaultAudioEndpoint(processId, flow, role, out var deviceId);
+        if (result != HRESULT.S_OK)
+        {
+            if (result != HRESULT.PROCESS_NO_AUDIO)
+            {
+                throw new InvalidComObjectException($"Can't set the persistent audio endpoint: {result}");
+            }
+
+            return null;
+        }
+
         var deviceIdStr = deviceId.ToString();
         deviceId.Dispose();
         return deviceIdStr;
     }
 
     public void ClearAllPersistedApplicationDefaultEndpoints()
     {
-        Marshal.ThrowExceptionForHR((int)_factory.ClearAllPersistedApplicationDefaultEndpoints());
+        var result = _factory.ClearAllPersistedApplicationDefaultEndpoints();
+        if (result != HRESULT.S_OK && result != HRESULT.PROCESS_NO_AUDIO)
+        {
+            throw new InvalidComObjectException($"Reset audio endpoints: {result}");
+        }
     }
 }

SoundSwitch.Audio.Manager/Interop/Client/ExtendedPolicyClient.cs

@@ -1,4 +1,5 @@
-using System;
+#nullable enable
+using System;
 using System.Collections.Generic;
 using System.Runtime.InteropServices;
 using Serilog;
@@ -41,8 +42,12 @@ private static string GenerateDeviceId(string deviceId, EDataFlow flow)
             return $"{MMDEVAPI_TOKEN}{deviceId}{(flow == EDataFlow.eRender ? DEVINTERFACE_AUDIO_RENDER : DEVINTERFACE_AUDIO_CAPTURE)}";
         }
 
-        private static string UnpackDeviceId(string deviceId)
+        private static string? UnpackDeviceId(string? deviceId)
         {
+            if (deviceId == null)
+            {
+                return null;
+            }
             if (deviceId.StartsWith(MMDEVAPI_TOKEN)) deviceId = deviceId.Remove(0, MMDEVAPI_TOKEN.Length);
             if (deviceId.EndsWith(DEVINTERFACE_AUDIO_RENDER)) deviceId = deviceId.Remove(deviceId.Length - DEVINTERFACE_AUDIO_RENDER.Length);
             if (deviceId.EndsWith(DEVINTERFACE_AUDIO_CAPTURE)) deviceId = deviceId.Remove(deviceId.Length - DEVINTERFACE_AUDIO_CAPTURE.Length);
@@ -78,7 +83,7 @@ public void SetDefaultEndPoint(string deviceId, EDataFlow flow, IEnumerable<ERol
         /// <summary>
         /// Get the deviceId of the current DefaultEndpoint
         /// </summary>
-        public string GetDefaultEndPoint(EDataFlow flow, ERole role, uint processId)
+        public string? GetDefaultEndPoint(EDataFlow flow, ERole role, uint processId)
         {
             try
             {

SoundSwitch.Audio.Manager/Interop/Enum/HRESULT.cs

@@ -7,5 +7,6 @@ public enum HRESULT : uint
         AUDCLNT_E_DEVICE_INVALIDATED = 0x88890004,
         AUDCLNT_S_NO_SINGLE_PROCESS = 0x889000d,
         ERROR_NOT_FOUND = 0x80070490,
+        PROCESS_NO_AUDIO = 0x80070057
     }
 }

SoundSwitch.Audio.Manager/Interop/Interface/Policy/Extended/IAudioPolicyConfig.cs

@@ -1,4 +1,5 @@
-using SoundSwitch.Audio.Manager.Interop.Enum;
+#nullable enable
+using SoundSwitch.Audio.Manager.Interop.Enum;
 
 namespace SoundSwitch.Audio.Manager.Interop.Interface.Policy.Extended;
 
@@ -19,7 +20,7 @@ public interface IAudioPolicyConfig
     /// <param name="processId"></param>
     /// <param name="flow"></param>
     /// <param name="role"></param>
-    string GetPersistedDefaultAudioEndpoint(uint processId, EDataFlow flow, ERole role);
+    string? GetPersistedDefaultAudioEndpoint(uint processId, EDataFlow flow, ERole role);
 
     /// <summary>
     /// Clear all set audio enpoint