fix(settings): fix issue with device list (settings) crashing when too many devices

The icon cache would evict icon used by the software.

Fixes SOUNDSWITCH-1XX
Fixes SOUNDSWITCH-1XB
Fixes SOUNDSWITCH-206

Author: Belphemur

SoundSwitch.Common/Framework/Audio/Icon/AudioDeviceIconExtractor.cs

@@ -12,11 +12,11 @@
  * GNU General Public License for more details.
  ********************************************************************/
 
+#nullable enable
 using System;
 using Microsoft.Extensions.Caching.Memory;
 using NAudio.CoreAudioApi;
 using Serilog;
-using SoundSwitch.Common.Framework.Icon;
 using SoundSwitch.Common.Properties;
 
 namespace SoundSwitch.Common.Framework.Audio.Icon
@@ -28,7 +28,7 @@ public class AudioDeviceIconExtractor
 
         private static readonly IMemoryCache IconCache = new MemoryCache(new MemoryCacheOptions
         {
-            SizeLimit = 5120
+            SizeLimit = 3200
         });
 
         private static string GetKey(MMDevice audioDevice, bool largeIcon)
@@ -45,7 +45,7 @@ private static string GetKey(MMDevice audioDevice, bool largeIcon)
         /// <returns></returns>
         public static System.Drawing.Icon ExtractIconFromPath(string path, DataFlow dataFlow, bool largeIcon)
         {
-            System.Drawing.Icon ExtractAssociatedIcon()
+            System.Drawing.Icon? ExtractAssociatedIcon()
             {
                 if (path.EndsWith(".ico"))
                 {
@@ -55,20 +55,24 @@ System.Drawing.Icon ExtractAssociatedIcon()
                 var iconInfo = path.Split(',');
                 var dllPath = iconInfo[0];
                 var iconIndex = int.Parse(iconInfo[1]);
-                return IconExtractor.Extract(dllPath, iconIndex, largeIcon);
+                return System.Drawing.Icon.ExtractIcon(dllPath, iconIndex, !largeIcon);
             }
 
             var key = $"{path}-${largeIcon}";
 
             if (IconCache.TryGetValue<System.Drawing.Icon>(key, out var icon))
-                return icon;
+                return icon!;
 
             try
             {
                 icon = ExtractAssociatedIcon();
+                if (icon == null)
+                {
+                    throw new ArgumentException("Can't find icon");
+                }
                 using var entry = IconCache.CreateEntry(key);
                 entry.SetValue(icon)
-                    .SetSize(icon.Size.Height * icon.Size.Width)
+                    .SetSize(icon.Size.Height)
                     .SetSlidingExpiration(TimeSpan.FromMinutes(30))
                     .SetPriority(largeIcon ? CacheItemPriority.High : CacheItemPriority.Low)
                     .RegisterPostEvictionCallback((o, value, reason, state) =>

SoundSwitch.Common/Framework/Icon/IconExtractor.cs

@@ -14,7 +14,6 @@
 //source : https://stackoverflow.com/questions/6872957/how-can-i-use-the-images-within-shell32-dll-in-my-c-sharp-project
 
 using System;
-using System.Runtime.InteropServices;
 using System.Runtime.Serialization;
 
 namespace SoundSwitch.Common.Framework.Icon
@@ -49,25 +48,14 @@ public static class IconExtractor
         /// <returns></returns>
         public static System.Drawing.Icon Extract(string file, int iconIndex, bool largeIcon)
         {
-            IntPtr large;
-            IntPtr small;
-            NativeMethods.ExtractIconEx(file, iconIndex, out large, out small, 1);
             try
             {
-                return System.Drawing.Icon.FromHandle(largeIcon ? large : small);
+                return System.Drawing.Icon.ExtractIcon(file, iconIndex, !largeIcon);
             }
             catch(Exception e)
             {
                 throw new IconExtractionException($"Can't extract icon from file: {file} / index:{iconIndex}", e);
             }
         }
-
-        private static class NativeMethods
-        {
-            [DllImport("Shell32.dll", EntryPoint = "ExtractIconExW", CharSet = CharSet.Unicode, ExactSpelling = true,
-                CallingConvention = CallingConvention.StdCall)]
-            public static extern int ExtractIconEx(string sFile, int iIndex, out IntPtr piLargeVersion,
-                out IntPtr piSmallVersion, int amountIcons);
-        }
     }
 }

SoundSwitch.Common/SoundSwitch.Common.csproj

@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFramework>netstandard2.1</TargetFramework>
+    <TargetFramework>net8.0-windows</TargetFramework>
     <OutputType>Library</OutputType>
     <Deterministic>false</Deterministic>
     <GenerateAssemblyInfo>true</GenerateAssemblyInfo>