fix(Notification::Sound): Fix issue where sound wasn't played properly.

Fixes SOUNDSWITCH-4Q

Author: Belphemur

SoundSwitch/Framework/NotificationManager/Notification/NotificationSound.cs

@@ -18,6 +18,7 @@
 using System.Threading.Tasks;
 using NAudio.CoreAudioApi;
 using NAudio.Wave;
+using Serilog;
 using SoundSwitch.Framework.Audio;
 using SoundSwitch.Framework.NotificationManager.Notification.Configuration;
 using SoundSwitch.Localization;
@@ -26,6 +27,7 @@ namespace SoundSwitch.Framework.NotificationManager.Notification
 {
     public class NotificationSound : INotification
     {
+        private CancellationTokenSource _cancellationTokenSource;
         public NotificationTypeEnum TypeEnum => NotificationTypeEnum.SoundNotification;
         public string               Label    => SettingsStrings.notificationOptionSound;
 
@@ -35,18 +37,33 @@ public void NotifyDefaultChanged(MMDevice audioDevice)
         {
             if (audioDevice.DataFlow != DataFlow.Render)
                 return;
-
-            Task.Factory.StartNew(() =>
+            
+            _cancellationTokenSource?.Cancel();
+            _cancellationTokenSource?.Dispose();
+            _cancellationTokenSource = new CancellationTokenSource();
+            Task.Factory.StartNew(async () =>
             {
-                using var memoryStreamedSound = GetStreamCopy();
-                using var output              = new WasapiOut(audioDevice, AudioClientShareMode.Shared, true, 10);
-                output.Init(new WaveFileReader(memoryStreamedSound));
-                output.Play();
-                while (output.PlaybackState == PlaybackState.Playing)
+                try
+                {
+                    using var cts = CancellationTokenSource.CreateLinkedTokenSource(_cancellationTokenSource.Token);
+                    using var player = new WasapiOut(audioDevice, AudioClientShareMode.Shared, true, 200);
+                    await using var memoryStreamedSound = GetStreamCopy();
+                    await using var waveStream = new WaveFileReader(memoryStreamedSound);
+                    player.Init(waveStream);
+
+                    player.PlaybackStopped += (_, _) => cts.CancelAfter(TimeSpan.FromMilliseconds(750));
+                    player.Play();
+                    await Task.Delay(-1, cts.Token);
+                }
+                catch (TaskCanceledException)
+                {
+                    //Ignored
+                }
+                catch (Exception e)
                 {
-                    Thread.Sleep(500);
+                    Log.Warning(e, "Issue while playing default sound");
                 }
-            });
+            }, _cancellationTokenSource.Token);
         }
 
         public void OnSoundChanged(CachedSound newSound)