Remove chunk splitting (#101)

Remove chunk splitting

Author: Kai Eichinger

.github/pull_request_template.md

@@ -1,10 +1,10 @@
 | Q             | A
-| ------------- | ---
-| Bug fix?      | yes/no
-| Improvement?  | yes/no <!-- improves an existing feature, not adding a new one --> 
-| New feature?  | yes/no <!-- don't forget to update CHANGELOG.md -->
-| BC breaks?    | no
-| Deprecations? | yes/no <!-- don't forget to update UPGRADE.md and CHANGELOG.md -->
-| Docs PR       | **missing** <!-- insert URL here -->
+| ------------- | --------------------------------------------------------------------- |
+| BC breaks?    | yes/no                                                                |
+| New feature?  | yes/no <!-- don't forget to update CHANGELOG.md -->                   |
+| Improvement?  | yes/no <!-- improves an existing feature, not adding a new one -->    |
+| Bug fix?      | yes/no                                                                |
+| Deprecations? | yes/no <!-- don't forget to update UPGRADE.md and CHANGELOG.md -->    |
+| Docs PR       | **missing** <!-- insert URL here -->                                  |
 
 <!-- describe your changes below -->

CHANGELOG.md

@@ -27,6 +27,7 @@
 *   (improvement) Improved ESLint linting: now only files in the project dir are linted. This ensures that symlinked dev packages are
     not linted. (`/node_modules/` etc are still excluded, of course.)
 *   (feature) Add option to polyfill core node packages in webpack.
+*   (bc) Remove `disableChunkSplitting()`, chunk splitting is now always disabled. Use code splitting instead.
 
 
 8.1.0

UPGRADE.md

@@ -4,6 +4,7 @@
 *   Internal: The project was ported to TypeScript.
 *   Always build a legacy and a modern JS build.
 *   Removed the ability to use the project's `tsconfig.json`. 
+*   Removed `disableChunkSplitting()`, chunk splitting is now always disabled. Use code splitting instead and remove the call to this method.
 
 
 7.x to 8.0

package.json

@@ -19,7 +19,7 @@
         "test": "npm run-script build && ava"
     },
     "optionalDependencies": {
-        "kaba-scss": "^3.1.0",
+        "kaba-scss": "^3.3.2",
         "webpack-bundle-analyzer": "^3.6.0"
     },
     "dependencies": {
@@ -50,7 +50,7 @@
     "devDependencies": {
         "@types/terser-webpack-plugin": "^2.2.0",
         "ava": "^2.4.0",
-        "kaba-scss": "^3.1.0",
+        "kaba-scss": "^3.3.2",
         "webpack-bundle-analyzer": "^3.6.0"
     },
     "engines": {

src/Kaba.ts

@@ -50,7 +50,6 @@ export class Kaba
     private moduleConcatenationEnabled: boolean = false;
     private plugins: webpack.Plugin[] = [];
     private javaScriptDependenciesFileName: string = "_dependencies";
-    private splitChunks: boolean = true;
     private hashFileNames: boolean = true;
     private buildModern: boolean = true;
     private nodeSettings: webpack.Node|false = false;
@@ -207,16 +206,6 @@ export class Kaba
     }
 
 
-    /**
-     * Disables chunk splitting
-     */
-    public disableChunkSplitting (): this
-    {
-        this.splitChunks = false;
-        return this;
-    }
-
-
     /**
      * Disables chunk hashes in file names
      */
@@ -388,30 +377,6 @@ export class Kaba
             node: this.nodeSettings,
         };
 
-        if (this.splitChunks)
-        {
-            (config.optimization as any).splitChunks = {
-                chunks: "all",
-                minChunks: 1,
-                maxAsyncRequests: 5,
-                maxInitialRequests: 3,
-                name: true,
-                cacheGroups: {
-                    default: {
-                        minChunks: 2,
-                        priority: -20,
-                        reuseExistingChunk: true,
-                    },
-                    vendors: {
-                        test: /[\\/]node_modules[\\/]/,
-                        priority: -10,
-                    },
-                },
-            };
-
-            (config.optimization as any).runtimeChunk = "single";
-        }
-
         if (!cliConfig.debug)
         {
             (config.optimization as any).minimizer.push(new TerserPlugin({

src/runner/SassRunner.ts

@@ -24,7 +24,7 @@ export class SassRunner
      *
      * @return {Promise<boolean>} whether the build was successful and error-free
      */
-    public async run () : Promise<boolean|null>
+    public async run () : Promise<boolean|void>
     {
         const entries = Object.keys(this.buildConfig.entries);