Update Azure Monitor readme.{go/python}.md with the latest specs (Azure#14542)

herreraj-ms · web-flow · commit 5ffa6f90f191 · 2021-06-17T13:25:32.000+08:00
* Update readme.{go/python}.md with the latest specs

* add new tag: package-2021-04

* Update list for package-2021-04

* Fix CSharpGen adding directive and fix refs in DCR

* Moving directive for all SDKs

* prettier changes

* directive only for go &amp; .net

* fixing go output-folder

* directive, remove azure-validator, add typescript

* fixing PR's LintDiff findings

* fixing breaking changes

* fixing go/python directives

* fix go build

* directive go &amp;&amp; package-2021-04

* fix go build prev package-2021-04

* fix java build
diff --git a/specification/monitor/resource-manager/Microsoft.Insights/stable/2021-04-01/dataCollectionEndpoints_API.json b/specification/monitor/resource-manager/Microsoft.Insights/stable/2021-04-01/dataCollectionEndpoints_API.json
@@ -50,7 +50,7 @@
           "default": {
             "description": "Error",
             "schema": {
-              "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
+              "$ref": "./dataCollectionRules_API.json#/definitions/ErrorResponseCommonV2"
             }
           }
         },
@@ -92,7 +92,7 @@
           "default": {
             "description": "Error",
             "schema": {
-              "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
+              "$ref": "./dataCollectionRules_API.json#/definitions/ErrorResponseCommonV2"
             }
           }
         },
@@ -140,7 +140,7 @@
           "default": {
             "description": "Error",
             "schema": {
-              "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
+              "$ref": "./dataCollectionRules_API.json#/definitions/ErrorResponseCommonV2"
             }
           }
         },
@@ -200,7 +200,7 @@
           "default": {
             "description": "Error",
             "schema": {
-              "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
+              "$ref": "./dataCollectionRules_API.json#/definitions/ErrorResponseCommonV2"
             }
           }
         },
@@ -254,7 +254,7 @@
           "default": {
             "description": "Error",
             "schema": {
-              "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
+              "$ref": "./dataCollectionRules_API.json#/definitions/ErrorResponseCommonV2"
             }
           }
         },
@@ -297,7 +297,7 @@
           "default": {
             "description": "Error",
             "schema": {
-              "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
+              "$ref": "./dataCollectionRules_API.json#/definitions/ErrorResponseCommonV2"
             }
           }
         },
diff --git a/specification/monitor/resource-manager/Microsoft.Insights/stable/2021-04-01/dataCollectionRuleAssociations_API.json b/specification/monitor/resource-manager/Microsoft.Insights/stable/2021-04-01/dataCollectionRuleAssociations_API.json
@@ -47,7 +47,7 @@
           "default": {
             "description": "Error",
             "schema": {
-              "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
+              "$ref": "./dataCollectionRules_API.json#/definitions/ErrorResponseCommonV2"
             }
           }
         },
@@ -95,7 +95,7 @@
           "default": {
             "description": "Error",
             "schema": {
-              "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
+              "$ref": "./dataCollectionRules_API.json#/definitions/ErrorResponseCommonV2"
             }
           }
         },
@@ -140,7 +140,7 @@
           "default": {
             "description": "Error",
             "schema": {
-              "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
+              "$ref": "./dataCollectionRules_API.json#/definitions/ErrorResponseCommonV2"
             }
           }
         },
@@ -197,7 +197,7 @@
           "default": {
             "description": "Error",
             "schema": {
-              "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
+              "$ref": "./dataCollectionRules_API.json#/definitions/ErrorResponseCommonV2"
             }
           }
         },
@@ -237,7 +237,7 @@
           "default": {
             "description": "Error",
             "schema": {
-              "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
+              "$ref": "./dataCollectionRules_API.json#/definitions/ErrorResponseCommonV2"
             }
           }
         },
diff --git a/specification/monitor/resource-manager/Microsoft.Insights/stable/2021-04-01/dataCollectionRules_API.json b/specification/monitor/resource-manager/Microsoft.Insights/stable/2021-04-01/dataCollectionRules_API.json
@@ -50,7 +50,7 @@
           "default": {
             "description": "Error",
             "schema": {
-              "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
+              "$ref": "#/definitions/ErrorResponseCommonV2"
             }
           }
         },
@@ -92,7 +92,7 @@
           "default": {
             "description": "Error",
             "schema": {
-              "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
+              "$ref": "#/definitions/ErrorResponseCommonV2"
             }
           }
         },
@@ -140,7 +140,7 @@
           "default": {
             "description": "Error",
             "schema": {
-              "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
+              "$ref": "#/definitions/ErrorResponseCommonV2"
             }
           }
         },
@@ -200,7 +200,7 @@
           "default": {
             "description": "Error",
             "schema": {
-              "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
+              "$ref": "#/definitions/ErrorResponseCommonV2"
             }
           }
         },
@@ -254,7 +254,7 @@
           "default": {
             "description": "Error",
             "schema": {
-              "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
+              "$ref": "#/definitions/ErrorResponseCommonV2"
             }
           }
         },
@@ -297,7 +297,7 @@
           "default": {
             "description": "Error",
             "schema": {
-              "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
+              "$ref": "#/definitions/ErrorResponseCommonV2"
             }
           }
         },
@@ -821,6 +821,17 @@
           }
         }
       }
+    },
+    "ErrorResponseCommonV2": {
+      "title": "Error response",
+      "description": "Common error response for all Azure Resource Manager APIs to return error details for failed operations. (This also follows the OData error response format.).",
+      "type": "object",
+      "properties": {
+        "error": {
+          "description": "The error object.",
+          "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorDetail"
+        }
+      }
     }
   },
   "parameters": {
diff --git a/specification/monitor/resource-manager/readme.csharp.md b/specification/monitor/resource-manager/readme.csharp.md
@@ -44,4 +44,12 @@ output-folder: $(csharp-sdks-folder)/$(csharp-profile)/Monitor/Management.Monito
 
 batch:
  - tag: profile-hybrid-2020-09-01
- ```
+ ```
+
+## Local Development
+
+### Auto Generation
+- Fork https://github.com/Azure/azure-rest-api-specs, clone it (asumming at C:\Repos) 
+- Fork https://github.com/Azure/azure-sdk-for-net, clone it (asumming at C:\Repos)
+- Make changes
+- autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=C:\Repos\azure-sdk-for-net\sdk C:\Repos\azure-rest-api-specs\specification\monitor\resource-manager\readme.md --debug
diff --git a/specification/monitor/resource-manager/readme.go.md b/specification/monitor/resource-manager/readme.go.md
@@ -21,6 +21,7 @@ batch:
   - tag: package-2019-06
   - tag: package-2019-11
   - tag: package-2020-10-only
+  - tag: package-2021-04
 ```
 
 ### Tag: package-2017-09 and go
@@ -94,3 +95,53 @@ Please also specify `--go-sdk-folder=<path to the root directory of your azure-s
 ``` yaml $(tag) == 'package-2020-10-only' && $(go)
 output-folder: $(go-sdk-folder)/services/monitor/mgmt/2020-10-01/$(namespace)
 ```
+
+### Tag: package-2021-04 and go
+
+These settings apply only when `--tag=package-2021-04 --go` is specified on the command line.
+Please also specify `--go-sdk-folder=<path to the root directory of your azure-sdk-for-go clone>`.
+
+``` yaml $(tag) == 'package-2021-04' && $(go)
+output-folder: $(go-sdk-folder)/services/preview/monitor/mgmt/2021-04-01-preview/$(namespace)
+directive:
+- from: activityLogAlerts_API.json
+  where: $.parameters
+  transform: delete $["ResourceGroupNameParameter"]
+  reason: ResourceGroupNameParameter is taken from v2/types.json
+- from: guestDiagnosticSettings_API.json
+  where: $.parameters
+  transform: delete $["ResourceGroupNameParameter"]
+  reason: ResourceGroupNameParameter is taken from v2/types.json
+- from: guestDiagnosticSettingsAssociation_API.json
+  where: $.parameters
+  transform: delete $["ResourceGroupNameParameter"]
+  reason: ResourceGroupNameParameter is taken from v2/types.json
+- from: privateLinkScopes_API.json
+  where: $.parameters
+  transform: delete $["ResourceGroupNameParameter"]
+  reason: ResourceGroupNameParameter is taken from v2/types.json
+- from: scheduledQueryRule_API.json
+  where: $.parameters
+  transform: delete $["ResourceGroupNameParameter"]
+  reason: ResourceGroupNameParameter is taken from v2/types.json
+- from: autoscale_API.json
+  where: $.parameters
+  transform: delete $["ResourceGroupNameParameter"]
+  reason: ResourceGroupNameParameter is taken from v2/types.json
+- from: alertRules_API.json
+  where: $.parameters
+  transform: delete $["ResourceGroupNameParameter"]
+  reason: ResourceGroupNameParameter is taken from v2/types.json
+- from: alertRulesIncidents_API.json
+  where: $.parameters
+  transform: delete $["ResourceGroupNameParameter"]
+  reason: ResourceGroupNameParameter is taken from v2/types.json
+- from: actionGroups_API.json
+  where: $.parameters
+  transform: delete $["ResourceGroupNameParameter"]
+  reason: ResourceGroupNameParameter is taken from v2/types.json
+- from: metricAlert_API.json
+  where: $.parameters
+  transform: delete $["ResourceGroupNameParameter"]
+  reason: ResourceGroupNameParameter is taken from v2/types.json
+```
diff --git a/specification/monitor/resource-manager/readme.md b/specification/monitor/resource-manager/readme.md
@@ -40,7 +40,38 @@ title: MonitorManagementClient
 ``` yaml
 description: Monitor Management Client
 openapi-type: arm
-tag: package-2020-03
+tag: package-2021-04
+```
+
+### Tag: package-2021-04
+
+These settings apply only when `--tag=package-2021-04` is specified on the command line.
+
+``` yaml $(tag) == 'package-2021-04'
+input-file:
+- Microsoft.Insights/stable/2015-04-01/autoscale_API.json
+- Microsoft.Insights/stable/2015-04-01/operations_API.json
+- Microsoft.Insights/stable/2016-03-01/alertRulesIncidents_API.json
+- Microsoft.Insights/stable/2016-03-01/alertRules_API.json
+- Microsoft.Insights/stable/2016-03-01/logProfiles_API.json
+- Microsoft.Insights/preview/2017-05-01-preview/diagnosticsSettings_API.json
+- Microsoft.Insights/preview/2017-05-01-preview/diagnosticsSettingsCategories_API.json
+- Microsoft.Insights/stable/2019-06-01/actionGroups_API.json
+- Microsoft.Insights/stable/2015-04-01/activityLogs_API.json
+- Microsoft.Insights/stable/2015-04-01/eventCategories_API.json
+- Microsoft.Insights/stable/2015-04-01/tenantActivityLogs_API.json
+- Microsoft.Insights/stable/2018-01-01/metricDefinitions_API.json
+- Microsoft.Insights/stable/2018-01-01/metrics_API.json
+- Microsoft.Insights/stable/2019-03-01/metricBaselines_API.json
+- Microsoft.Insights/stable/2018-03-01/metricAlert_API.json
+- Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json
+- Microsoft.Insights/preview/2017-12-01-preview/metricNamespaces_API.json
+- Microsoft.Insights/preview/2018-11-27-preview/vmInsightsOnboarding_API.json
+- Microsoft.Insights/preview/2019-10-17-preview/privateLinkScopes_API.json
+- Microsoft.Insights/stable/2017-04-01/activityLogAlerts_API.json
+- Microsoft.Insights/stable/2021-04-01/dataCollectionEndpoints_API.json
+- Microsoft.Insights/stable/2021-04-01/dataCollectionRuleAssociations_API.json
+- Microsoft.Insights/stable/2021-04-01/dataCollectionRules_API.json
 ```
 ### Tag: package-2021-05-01-preview-only
 
@@ -692,6 +723,58 @@ directive:
     reason: 'Updating the error response to the new format would be a breaking change.'
 ```
 
+``` yaml $(go) || $(csharp) || $(validation) || $(typescript)
+directive:
+- from: activityLogAlerts_API.json
+  where: $.definitions
+  transform: delete $["Resource"]
+  reason: Missing kind, etag; Generation will take the definition from scheduledQueryRule_API.json which includes kind & etag
+```
+
+``` yaml !$(python) && !$(go) && !$(java)
+directive:
+- from: activityLogAlerts_API.json
+  where: $.parameters
+  transform: delete $["ResourceGroupNameParameter"]
+  reason: ResourceGroupNameParameter is taken from v2/types.json
+- from: guestDiagnosticSettings_API.json
+  where: $.parameters
+  transform: delete $["ResourceGroupNameParameter"]
+  reason: ResourceGroupNameParameter is taken from v2/types.json
+- from: guestDiagnosticSettingsAssociation_API.json
+  where: $.parameters
+  transform: delete $["ResourceGroupNameParameter"]
+  reason: ResourceGroupNameParameter is taken from v2/types.json
+- from: privateLinkScopes_API.json
+  where: $.parameters
+  transform: delete $["ResourceGroupNameParameter"]
+  reason: ResourceGroupNameParameter is taken from v2/types.json
+- from: scheduledQueryRule_API.json
+  where: $.parameters
+  transform: delete $["ResourceGroupNameParameter"]
+  reason: ResourceGroupNameParameter is taken from v2/types.json
+- from: autoscale_API.json
+  where: $.parameters
+  transform: delete $["ResourceGroupNameParameter"]
+  reason: ResourceGroupNameParameter is taken from v2/types.json
+- from: alertRules_API.json
+  where: $.parameters
+  transform: delete $["ResourceGroupNameParameter"]
+  reason: ResourceGroupNameParameter is taken from v2/types.json
+- from: alertRulesIncidents_API.json
+  where: $.parameters
+  transform: delete $["ResourceGroupNameParameter"]
+  reason: ResourceGroupNameParameter is taken from v2/types.json
+- from: actionGroups_API.json
+  where: $.parameters
+  transform: delete $["ResourceGroupNameParameter"]
+  reason: ResourceGroupNameParameter is taken from v2/types.json
+- from: metricAlert_API.json
+  where: $.parameters
+  transform: delete $["ResourceGroupNameParameter"]
+  reason: ResourceGroupNameParameter is taken from v2/types.json
+```
+
 ### Tag: profile-hybrid-2019-03-01
 
 These settings apply only when `--tag=profile-hybrid-2019-03-01` is specified on the command line.
diff --git a/specification/monitor/resource-manager/readme.python.md b/specification/monitor/resource-manager/readme.python.md
@@ -30,6 +30,7 @@ Generate all API versions currently shipped for this package
 clear-output-folder: true
 batch:
   - tag: package-2021-05-01-preview-only
+  - tag: package-2021-04-only
   - tag: package-2020-10-only
   - tag: package-2020-05-preview-only
   - tag: package-2020-01-01-preview-only
@@ -70,6 +71,16 @@ namespace: $(python-base-namespace).v2021_05_01_preview
 output-folder: $(python-sdks-folder)/$(python-base-folder)/v2021_05_01_preview
 ```
 
+### Tag: package-2021-04-only and python
+
+These settings apply only when `--tag=package-2021-04-only --python` is specified on the command line.
+Please also specify `--python-sdks-folder=<path to the root directory of your azure-sdk-for-python clone>`.
+
+``` yaml $(tag) == 'package-2021-04-only'
+namespace: $(python-base-namespace).v2021_04_01
+output-folder: $(python-sdks-folder)/$(python-base-folder)/v2021_04_01
+```
+
 ### Tag: package-2020-10-only and python
 
 These settings apply only when `--tag=package-2020-10-only --python` is specified on the command line.

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@`
`50`	`50`	`"default": {`
`51`	`51`	`"description": "Error",`
`52`	`52`	`"schema": {`
`53`		`- "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"`
	`53`	`+ "$ref": "./dataCollectionRules_API.json#/definitions/ErrorResponseCommonV2"`
`54`	`54`	`}`
`55`	`55`	`}`
`56`	`56`	`},`
`@@ -92,7 +92,7 @@`
`92`	`92`	`"default": {`
`93`	`93`	`"description": "Error",`
`94`	`94`	`"schema": {`
`95`		`- "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"`
	`95`	`+ "$ref": "./dataCollectionRules_API.json#/definitions/ErrorResponseCommonV2"`
`96`	`96`	`}`
`97`	`97`	`}`
`98`	`98`	`},`
`@@ -140,7 +140,7 @@`
`140`	`140`	`"default": {`
`141`	`141`	`"description": "Error",`
`142`	`142`	`"schema": {`
`143`		`- "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"`
	`143`	`+ "$ref": "./dataCollectionRules_API.json#/definitions/ErrorResponseCommonV2"`
`144`	`144`	`}`
`145`	`145`	`}`
`146`	`146`	`},`
`@@ -200,7 +200,7 @@`
`200`	`200`	`"default": {`
`201`	`201`	`"description": "Error",`
`202`	`202`	`"schema": {`
`203`		`- "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"`
	`203`	`+ "$ref": "./dataCollectionRules_API.json#/definitions/ErrorResponseCommonV2"`
`204`	`204`	`}`
`205`	`205`	`}`
`206`	`206`	`},`
`@@ -254,7 +254,7 @@`
`254`	`254`	`"default": {`
`255`	`255`	`"description": "Error",`
`256`	`256`	`"schema": {`
`257`		`- "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"`
	`257`	`+ "$ref": "./dataCollectionRules_API.json#/definitions/ErrorResponseCommonV2"`
`258`	`258`	`}`
`259`	`259`	`}`
`260`	`260`	`},`
`@@ -297,7 +297,7 @@`
`297`	`297`	`"default": {`
`298`	`298`	`"description": "Error",`
`299`	`299`	`"schema": {`
`300`		`- "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"`
	`300`	`+ "$ref": "./dataCollectionRules_API.json#/definitions/ErrorResponseCommonV2"`
`301`	`301`	`}`
`302`	`302`	`}`
`303`	`303`	`},`
Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@`
`47`	`47`	`"default": {`
`48`	`48`	`"description": "Error",`
`49`	`49`	`"schema": {`
`50`		`- "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"`
	`50`	`+ "$ref": "./dataCollectionRules_API.json#/definitions/ErrorResponseCommonV2"`
`51`	`51`	`}`
`52`	`52`	`}`
`53`	`53`	`},`
`@@ -95,7 +95,7 @@`
`95`	`95`	`"default": {`
`96`	`96`	`"description": "Error",`
`97`	`97`	`"schema": {`
`98`		`- "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"`
	`98`	`+ "$ref": "./dataCollectionRules_API.json#/definitions/ErrorResponseCommonV2"`
`99`	`99`	`}`
`100`	`100`	`}`
`101`	`101`	`},`
`@@ -140,7 +140,7 @@`
`140`	`140`	`"default": {`
`141`	`141`	`"description": "Error",`
`142`	`142`	`"schema": {`
`143`		`- "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"`
	`143`	`+ "$ref": "./dataCollectionRules_API.json#/definitions/ErrorResponseCommonV2"`
`144`	`144`	`}`
`145`	`145`	`}`
`146`	`146`	`},`
`@@ -197,7 +197,7 @@`
`197`	`197`	`"default": {`
`198`	`198`	`"description": "Error",`
`199`	`199`	`"schema": {`
`200`		`- "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"`
	`200`	`+ "$ref": "./dataCollectionRules_API.json#/definitions/ErrorResponseCommonV2"`
`201`	`201`	`}`
`202`	`202`	`}`
`203`	`203`	`},`
`@@ -237,7 +237,7 @@`
`237`	`237`	`"default": {`
`238`	`238`	`"description": "Error",`
`239`	`239`	`"schema": {`
`240`		`- "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"`
	`240`	`+ "$ref": "./dataCollectionRules_API.json#/definitions/ErrorResponseCommonV2"`
`241`	`241`	`}`
`242`	`242`	`}`
`243`	`243`	`},`