Fix flaky test ReceiveLotOfMessagesWithoutSettling in Microsoft.Azure.ServiceBus (Azure#19454)

* add changelog for a new nuget minor version bump

* Revert "add changelog for a new nuget minor version bump"

This reverts commit 7ece7b5.

* add change log for amqp lib update

* try to run failed tests

* try to fix the flaky test

* try to fix the flaky test

* clean up unnecessary comments

* make timeout a configurable parameter for test

Author: DorothySun216

sdk/servicebus/Microsoft.Azure.ServiceBus/tests/QueueClientTests.cs

@@ -3,6 +3,7 @@
 
 namespace Microsoft.Azure.ServiceBus.UnitTests
 {
+    using System;
     using System.Collections.Generic;
     using System.Linq;
     using System.Threading.Tasks;
@@ -102,7 +103,7 @@ await ServiceBusScope.UsingQueueAsync(partitioned, sessionEnabled, async queueNa
                 var queueClient = new QueueClient(TestUtility.NamespaceConnectionString, queueName, ReceiveMode.ReceiveAndDelete);
                 try
                 {
-                    await this.ReceiveDeleteTestCase(queueClient.InnerSender, queueClient.InnerReceiver, messageCount);
+                    await this.ReceiveDeleteTestCase(queueClient.InnerSender, queueClient.InnerReceiver, messageCount, TimeSpan.FromSeconds(10));
                 }
                 finally
                 {

sdk/servicebus/Microsoft.Azure.ServiceBus/tests/SenderReceiverClientTestBase.cs

@@ -22,10 +22,10 @@ internal async Task PeekLockTestCase(IMessageSender messageSender, IMessageRecei
             await TestUtility.CompleteMessagesAsync(messageReceiver, receivedMessages);
         }
 
-        internal async Task ReceiveDeleteTestCase(IMessageSender messageSender, IMessageReceiver messageReceiver, int messageCount)
+        internal async Task ReceiveDeleteTestCase(IMessageSender messageSender, IMessageReceiver messageReceiver, int messageCount, TimeSpan timeout)
         {
             await TestUtility.SendMessagesAsync(messageSender, messageCount);
-            var receivedMessages = await TestUtility.ReceiveMessagesAsync(messageReceiver, messageCount, TimeSpan.FromSeconds(10));
+            var receivedMessages = await TestUtility.ReceiveMessagesAsync(messageReceiver, messageCount, timeout);
             Assert.Equal(messageCount, receivedMessages.Count);
         }
 

sdk/servicebus/Microsoft.Azure.ServiceBus/tests/SenderReceiverTests.cs

@@ -45,7 +45,7 @@ await ServiceBusScope.UsingQueueAsync(partitioned, sessionEnabled, async queueNa
             });
         }
 
-        [Fact(Skip="Flaky test. Tracked by #16265")]
+        [Fact]
         [LiveTest]
         [DisplayTestMethodName]
         public async Task ReceiveLotOfMessagesWithoutSettling()
@@ -59,7 +59,7 @@ await ServiceBusScope.UsingQueueAsync(false, false, async queueName =>
 
                 try
                 {
-                    await this.ReceiveDeleteTestCase(sender, receiver, messageCount);
+                    await this.ReceiveDeleteTestCase(sender, receiver, messageCount, TimeSpan.FromMinutes(2));
                 }
                 finally
                 {

sdk/servicebus/Microsoft.Azure.ServiceBus/tests/TopicClientTests.cs

@@ -3,6 +3,7 @@
 
 namespace Microsoft.Azure.ServiceBus.UnitTests
 {
+    using System;
     using System.Collections.Generic;
     using System.Threading.Tasks;
     using Xunit;
@@ -65,7 +66,8 @@ await ServiceBusScope.UsingTopicAsync(partitioned, sessionEnabled, async (topicN
                         this.ReceiveDeleteTestCase(
                             topicClient.InnerSender,
                             subscriptionClient.InnerSubscriptionClient.InnerReceiver,
-                            messageCount);
+                            messageCount,
+                            TimeSpan.FromSeconds(10));
                 }
                 finally
                 {