Commit e1f7a50
authored
[Identity] No more inMemoryPersistence! (Azure#14530)
Now that we've released 2.0.0-beta.1 and the Identity hotfix that I
wanted to release, I was able to sit down and start writing a sample
showcasing some of the "bugs" I found. This helped me bounce against
the code and eventually figure out that it was in fact _me_ who had
written a bug!
This if:
```ts
if (this.publicApp && this.confidentialApp) {
return;
}
```
in the code that defines the configuration for Node.js was causing the
MSAL client to be defined multiple times, rendering the in-memory cache
as useless.
The solution? To switch `&&` to `||`.
It seems obvious in retrospective!
This means that there's no need neither for the `inMemoryCache`, nor for
the line that I used to "read" from the cache. Therefore:
Fixes Azure#14372
Fixes Azure#143731 parent e050256 commit e1f7a50
File tree
2 files changed
+1
-54
lines changed- sdk/identity/identity/src
- msal/nodeFlows
- tokenCache
2 files changed
+1
-54
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
| |||
56 | 55 | | |
57 | 56 | | |
58 | 57 | | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | 58 | | |
64 | 59 | | |
65 | 60 | | |
| |||
102 | 97 | | |
103 | 98 | | |
104 | 99 | | |
105 | | - | |
| 100 | + | |
106 | 101 | | |
107 | 102 | | |
108 | 103 | | |
| |||
210 | 205 | | |
211 | 206 | | |
212 | 207 | | |
213 | | - | |
214 | | - | |
215 | | - | |
216 | | - | |
217 | | - | |
218 | 208 | | |
219 | 209 | | |
220 | 210 | | |
| |||
Lines changed: 0 additions & 43 deletions
This file was deleted.
0 commit comments