Skip to content

Commit 3f72e22

Browse files
authored
[Git precommit hook] Deleted (Azure#13982)
This PR deletes the git precommit hook after folks complained about it. I am keeping the rush prettier command in case anyone wants to keep the hook locally. I will merge this PR after I add a step for formatting checking in CI.
1 parent e28dc30 commit 3f72e22

File tree

2 files changed

+4
-23
lines changed

2 files changed

+4
-23
lines changed

CONTRIBUTING.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -233,6 +233,10 @@ To maintain the quality of the documentation, the following two facilities are p
233233

234234
TSDoc specifications can be customized using the `tsdoc.json` configuration file that can be found in the root of the repository. Currently, the `@hidden` tag is used which is only supported by TypeDoc and is not a TSDoc tag, so it is added as a custom tag in `tsdoc.json`.
235235

236+
### Formatting changed files
237+
238+
We used to have a git hook that formats your changed files on commit but it was removed because it did not work well for some people for various reasons. If you would like to enable it in your fork, you will need to just revert this [PR](https://github.com/Azure/azure-sdk-for-js/pull/13982/) in your branch and then run `rush update` so the hook script gets copied into `.git/hooks`. Moreover, without the hook, you can manually format changed files by invoking `rush prettier`.
239+
236240
## Onboarding a new library
237241

238242
All libraries must follow our [repository structure](https://github.com/Azure/azure-sdk/blob/master/docs/policies/repostructure.md) (specifically, it must be located at `sdk/<servicename>/<packagename>`) and your library's `package.json` must contain the required scripts as documented [above](#other-npm-scripts).

common/git-hooks/pre-commit

Lines changed: 0 additions & 23 deletions
This file was deleted.

0 commit comments

Comments
 (0)