Skip to content

Commit 3e253a9

Browse files
jonathan-innisyuyue9284Yue Yuliakaz
authored
[k8s-extension] HotFix Broken calls to ServiceBus for Track2 models (Azure#3439)
* Create pull.yml * Update pull.yml * Update azure-pipelines.yml * Initial commit of k8s-extension * Update pipelines file * Update CODEOWNERS * Update private preview pipelines * Remove open service mesh from public release * Update pipeline files * Update public extension pipeline * Change condition variable * Add version to public preview/private preview * Update pipelines * Add different testing based on private branch * Add annotations to extension model * Update k8s-custom-pipelines.yml * Update SDKs with Updated Swagger Spec for 2020-07-01-preview (#13) * Update sdks with updated swagger spec * Update version and history rst * Reorder release history timeline * Fix ExtensionInstanceForCreate for import * remove py2 bdist support * Add custom table formatting * Remove unnecessary files * Fix style issues * Fix branch based on comments * Update identity piece manually * Don't handle defaults at the CLI level * Remove defaults from CLI client * Check null target namespace with namespace scope * Update style * Add cassandra operator and location to model * Stage Public Version of k8s-extension 0.2.0 for official release (#15) * Create pull.yml * Update pull.yml * Update azure-pipelines.yml * Initial commit of k8s-extension * Update pipelines file * Update CODEOWNERS * Update private preview pipelines * Remove open service mesh from public release * Update pipeline files * Update public extension pipeline * Change condition variable * Add version to public preview/private preview * Update pipelines * Add different testing based on private branch * Add annotations to extension model * Update k8s-custom-pipelines.yml * Update SDKs with Updated Swagger Spec for 2020-07-01-preview (#13) * Update sdks with updated swagger spec * Update version and history rst * Reorder release history timeline * Fix ExtensionInstanceForCreate for import * remove py2 bdist support * Add custom table formatting * Remove unnecessary files * Fix style issues * Fix branch based on comments * Update identity piece manually * Don't handle defaults at the CLI level * Remove defaults from CLI client * Check null target namespace with namespace scope * Update style * Add cassandra operator and location to model Co-authored-by: [email protected] <Action - Fork Sync> * Remove custom pipelines file * Update extension description, remove private const * Update pipeline file * Disable refs docs * Update to include better create warning logs and remove update context (#20) * Update to include better create warning logs and remove update context * Remove help text for update * Fix spelling error * Update message * Fix k8s-extension conflict with private version * Fix style errors * Fix filename * add customization for microsoft.azureml.kubernetes (#23) * add customization for microsoft.azureml.kubernetes * Update release history Co-authored-by: Yue Yu <[email protected]> Co-authored-by: jonathan-innis <[email protected]> * Add E2E Testing from Separate branch into internal code (#26) * Add internal e2e testing * Change to testing folder * Inference CLI validation for Scoring FE (#24) * cli validation starter * added the call to the fe validation function * nodeport validation not required * test fix Co-authored-by: Jonathan Innis <[email protected]> * legal warning added (#27) * Remove deprecated method logger.warn * Update k8s-custom-pipelines.yml for Azure Pipelines * Update k8s-custom-pipelines.yml for Azure Pipelines * Add Azure Defender to E2E testing (#28) * Add azure defender testing to e2e * Remove the debug flag * Add configuration testing * Fix pipeline failures * Make test script more intuitive * Remove parameter from testing * Fix wrong location for k8s config whl * Fix pip upgrade issue * Fix pip install upgrade issue * Fix pip install issue * delete resurce in testcase (#29) Co-authored-by: Yue Yu <[email protected]> Co-authored-by: Jonathan Innis <[email protected]> * Check Provider is Registered with Subscription Before Making Requests (#18) * Add check for KubernetesConfiguration * Disable pylint and rename * Update provider registration link * Update version * Remove extra blank line * Fix bug in import * only validate scoring fe when inference is enabled (#31) * only validate scoring fe when inference is enabled * Fix versioning Co-authored-by: Yue Yu <[email protected]> Co-authored-by: jonathan-innis <[email protected]> * Provider registration case insensitive * do not validate against scoring fe if inference is not enabled. (#33) * do not validate against scoring fe if inference is not enabled. * add inference enabled scenario * refine * increase sleeping time * fix Co-authored-by: Yue Yu <[email protected]> Co-authored-by: Jonathan Innis <[email protected]> * Add OSM as Public Preview Extension (#34) * Add OSM as public preview extension * Add osm testing * Add release train to tests * Fix failing osm test * Upgrade pip in integration testing * Remove ununsed import * Fix release train check in update * Parallelize E2E Testing (#36) * Add OSM as public preview extension * Add osm testing * Update test logic to parallelize * Fix test success checking * Parallelize extension testing * Better error checking logic * Fix azureml deletion * Fix private build (#40) * change amlk8s to amlarc (#42) Co-authored-by: Yue Yu <[email protected]> * Servicebus client model changes (#44) * Servicebus client model changes * Fix testing script * Update history file and pipeline * Update min cli core version for track 2 updates * remove unneeded files for staging Co-authored-by: [email protected] <Action - Fork Sync> Co-authored-by: yuyue9284 <[email protected]> Co-authored-by: Yue Yu <[email protected]> Co-authored-by: Lia Kazakova <[email protected]>
1 parent ef102a7 commit 3e253a9

File tree

6 files changed

+15
-11
lines changed

6 files changed

+15
-11
lines changed

src/k8s-extension/HISTORY.rst

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,12 @@
33
Release History
44
===============
55

6+
0.4.2
7+
++++++++++++++++++
8+
9+
* Hotfix servicebus namespace creation for Track 2 changes
10+
* Change resource tag from 'amlk8s' to 'Azure Arc-enabled ML' in microsoft.azureml.kubernetes
11+
612
0.4.1
713
++++++++++++++++++
814

src/k8s-extension/azext_k8s_extension/_validators.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
# --------------------------------------------------------------------------------------------
55

66
from knack.log import get_logger
7-
from azext_k8s_extension._client_factory import _resource_providers_client
7+
from ._client_factory import _resource_providers_client
88
from . import consts
99

1010

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
{
22
"azext.isPreview": true,
3-
"azext.minCliCoreVersion": "2.15.0"
3+
"azext.minCliCoreVersion": "2.24.0"
44
}

src/k8s-extension/azext_k8s_extension/custom.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,8 @@
1313
from azure.cli.core.azclierror import ResourceNotFoundError, MutuallyExclusiveArgumentError, \
1414
InvalidArgumentValueError, CommandNotFoundError, RequiredArgumentMissingError
1515
from azure.cli.core.commands.client_factory import get_subscription_id
16-
from azext_k8s_extension.vendored_sdks.models import ConfigurationIdentity
17-
from azext_k8s_extension.vendored_sdks.models import ErrorResponseException
18-
from azext_k8s_extension.vendored_sdks.models import Scope
19-
from azext_k8s_extension._validators import validate_cc_registration
16+
from .vendored_sdks.models import ConfigurationIdentity, ErrorResponseException, Scope
17+
from ._validators import validate_cc_registration
2018

2119
from .partner_extensions.ContainerInsights import ContainerInsights
2220
from .partner_extensions.AzureDefender import AzureDefender

src/k8s-extension/azext_k8s_extension/partner_extensions/AzureMLKubernetes.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030

3131
logger = get_logger(__name__)
3232

33-
resource_tag = {'created_by': 'amlk8s-extension'}
33+
resource_tag = {'created_by': 'Azure Arc-enabled ML'}
3434

3535

3636
class AzureMLKubernetes(PartnerExtensionModel):
@@ -271,10 +271,10 @@ def _lock_resource(cmd, lock_scope, lock_level='CanNotDelete'):
271271
lock_client: azure.mgmt.resource.locks.ManagementLockClient = get_mgmt_service_client(
272272
cmd.cli_ctx, azure.mgmt.resource.locks.ManagementLockClient)
273273
# put lock on relay resource
274-
lock_object = ManagementLockObject(level=lock_level, notes='locked by amlk8s.')
274+
lock_object = ManagementLockObject(level=lock_level, notes='locked by amlarc.')
275275
try:
276276
lock_client.management_locks.create_or_update_by_scope(
277-
scope=lock_scope, lock_name='amlk8s-resource-lock', parameters=lock_object)
277+
scope=lock_scope, lock_name='amlarc-resource-lock', parameters=lock_object)
278278
except:
279279
# try to lock the resource if user has the owner privilege
280280
pass
@@ -337,7 +337,7 @@ def _get_service_bus_connection_string(cmd, subscription_id, resource_group_name
337337
location=cluster_location,
338338
sku=service_bus_sku,
339339
tags=resource_tag)
340-
async_poller = service_bus_client.namespaces.create_or_update(
340+
async_poller = service_bus_client.namespaces.begin_create_or_update(
341341
resource_group_name, service_bus_namespace_name, service_bus_namespace)
342342
while True:
343343
async_poller.result(15)

src/k8s-extension/setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
# TODO: Add any additional SDK dependencies here
3333
DEPENDENCIES = []
3434

35-
VERSION = "0.4.1"
35+
VERSION = "0.4.2"
3636

3737
with open('README.rst', 'r', encoding='utf-8') as f:
3838
README = f.read()

0 commit comments

Comments
 (0)