Skip to content
This repository was archived by the owner on May 13, 2025. It is now read-only.

Commit b2f1319

Browse files
Upgrade Python version from 3.6 to 3.7 (#203)
* Upgrade Python version from 3.6 to 3.10 Upgrade to 3.10 for the job that runs Wheel, PyLint, Flake, etc., since 3.6 is not supported anymore by hosted-agent-software. * Upgrade to Python 3.10 from 3.6 Upgrade to 3.10 as 3.6 is not supported * Switch PyLink to 1.9.4 Switch PyLink to 1.9.4 from 1.9.5, as 1.9.5 is not supported with Python 3.10 * Use Python 3.7 for Static Analysis Use 3.7, as 3.10 does not support certain properties used by astpeephole.py that is used by Static Analysis tools * Try unpinned version of PyLint PyLint 1.9.5 doesn't work with Python 3.7. So, trying to see if it automatically pulls the latest compatible version. * Run pylint as a separate command * Update pylintrc (#204) * Update pylintrc * Update k8s-custom-pipelines.yml * Disable PyLint (#205) Disable PyLint for now, as the new version has breaking changes and requires lot more fixes * Disable PyLint on CI scripts * Fixes for script errors * Upgrade Static Analysis Python version Upgrade the Python version for Static Analysis to 3.10, from 3.7, now that PyLint is disabled * Try 3.9, as 3.10 has breaking changes for Flake8 * Remove version pinning for flake8 Try Python 3.10, without pinning flake8 to a version * Update k8s-custom-pipelines.yml * Use Python 3.8.1 & flake8 6.0.0 * Use Python 3.8 instead of 3.8.1 * Update k8s-custom-pipelines.yml * Update .flake8 Update to reflect breaking change in flake8 6.0 * Update source_code_static_analysis.py Scope static analysis tools to only k8s-extension module's source in our branch. * Update k8s-custom-pipelines.yml * Update k8s-custom-pipelines.yml * Update k8s-custom-pipelines.yml * Update pool name in StaticAnalysis To mirror what is in main of azure-cli-extensions * Update k8s-custom-pipelines.yml * Fix indentation * Update k8s-custom-pipelines.yml * Update k8s-custom-pipelines.yml * Revert changes * Revert changes * Revert changes to source_code_static_analysis.py * Update source_code_static_analysis.py * Revert changes * Use Ubuntu 20.4 for BuiltTestPublish stage * Switch to ubuntu-20.04 from latest Co-authored-by: Rishik Hombal <[email protected]>
1 parent d54d6ab commit b2f1319

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

testing/pipeline/k8s-custom-pipelines.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ stages:
5555
path: ./test/extensions/public/Flux.Tests.ps1
5656
- job: BuildPublishExtension
5757
pool:
58-
vmImage: 'ubuntu-latest'
58+
vmImage: 'ubuntu-20.04'
5959
displayName: "Build and Publish the Extension Artifact"
6060
variables:
6161
CLI_REPO_PATH: $(Agent.BuildDirectory)/s
@@ -105,10 +105,11 @@ stages:
105105
106106
azdev verify license
107107
108+
108109
- job: StaticAnalysis
109110
displayName: "Static Analysis"
110111
pool:
111-
vmImage: 'ubuntu-latest'
112+
vmImage: 'ubuntu-20.04'
112113
steps:
113114
- task: UsePythonVersion@0
114115
displayName: 'Use Python 3.6'
@@ -209,4 +210,4 @@ stages:
209210
displayName: "CLI Linter on Modified Extension"
210211
env:
211212
ADO_PULL_REQUEST_LATEST_COMMIT: $(System.PullRequest.SourceCommitId)
212-
ADO_PULL_REQUEST_TARGET_BRANCH: $(System.PullRequest.TargetBranch)
213+
ADO_PULL_REQUEST_TARGET_BRANCH: $(System.PullRequest.TargetBranch)

testing/pipeline/templates/build-extension.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,4 +49,4 @@ steps:
4949
5050
azdev --version
5151
azdev setup -c ../azure-cli -r ${{ parameters.CLI_REPO_PATH }} -e $(EXTENSION_NAME)
52-
azdev extension build $(EXTENSION_NAME)
52+
azdev extension build $(EXTENSION_NAME)

testing/pipeline/templates/run-test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ parameters:
55
jobs:
66
- job: ${{ parameters.jobName}}
77
pool:
8-
vmImage: 'ubuntu-latest'
8+
vmImage: 'ubuntu-20.04'
99
variables:
1010
${{ if eq(variables['IS_PRIVATE_BRANCH'], 'False') }}:
1111
EXTENSION_NAME: "k8s-extension"
@@ -101,4 +101,4 @@ jobs:
101101
inlineScript: |
102102
.\Cleanup.ps1 -CI
103103
workingDirectory: $(TEST_PATH)
104-
condition: succeededOrFailed()
104+
condition: succeededOrFailed()

0 commit comments

Comments
 (0)