Skip to content

Fix Id Web Build #2991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Fix Id Web Build #2991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Microsoft.Identity.Web.TokenAcquisition/MergedOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,8 @@ internal static void UpdateMergedOptionsFromMicrosoftIdentityOptions(MicrosoftId
mergedOptions.AdditionalAuthorizationParameters.Add(parameter.Key, parameter.Value);
}
}

mergedOptions.PushedAuthorizationBehavior = microsoftIdentityOptions.PushedAuthorizationBehavior;
#endif
mergedOptions.TokenValidationParameters = microsoftIdentityOptions.TokenValidationParameters.Clone();
mergedOptions.UsePkce |= microsoftIdentityOptions.UsePkce;
Expand Down
2 changes: 2 additions & 0 deletions ...t.Identity.Web/WebAppExtensions/MicrosoftIdentityWebAppAuthenticationBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,6 +544,8 @@ internal static void PopulateOpenIdOptionsFromMergedOptions(
options.AdditionalAuthorizationParameters.Add(parameter.Key, parameter.Value);
}
}

options.PushedAuthorizationBehavior = mergedOptions.PushedAuthorizationBehavior;
#endif
}
}
Expand Down
2 changes: 1 addition & 1 deletion tests/Microsoft.Identity.Web.Test/WebAppExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -913,7 +913,7 @@ public void PreventChangesInOpenIdConnectOptionsToBeOverlooked()
// and diff the files to find what are the new properties.
int numberOfProperties = typeof(OpenIdConnectOptions).GetProperties(System.Reflection.BindingFlags.Public | System.Reflection.BindingFlags.Instance).Length;
#if NET9_0_OR_GREATER
int expectedNumberOfProperties = 61;
int expectedNumberOfProperties = 62;
//string filePath = @"C:\temp\net9.txt";
#elif NET8_0
int expectedNumberOfProperties = 60;
Expand Down