Jmprieur/add ciam dev apps #2399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the CIAM authority is propagated to the options - it's a v2.0 authority for JwtBearer - The metadata endpoint is computed, including when extra query parameters.
jennyf19
reviewed
Aug 24, 2023
...soft.Identity.Web/WebApiExtensions/MicrosoftIdentityWebApiAuthenticationBuilderExtensions.cs
Show resolved
Hide resolved
jennyf19
reviewed
Aug 24, 2023
jennyf19
reviewed
Aug 24, 2023
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.AspNetCore.OpenApi" Version="7.0.10" /> |
Collaborator
Collaborator
Author
There was a problem hiding this comment.
I'll address this later (with the fact that it's still using IDownstreamWebApi. It's straight from the project templates)
jennyf19
reviewed
Aug 24, 2023
Collaborator
|
not a fan of adding more dev apps, but I understand why :) |
…ions> are done (that is in the JwtBearerOptionsMerger, which is a PostConfigure Fixed a flaky test Added code to initialize Playwright
Collaborator
Author
We need to catch regressions |
Collaborator
Author
|
@westin-m, @JoshLozensky anybody else want to review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CIAM samples and fix web API authority