Skip to content

Making GetClientAssertion method public #2112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 17, 2023
Merged

Making GetClientAssertion method public #2112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eb329d0
Making GetClientAssertion method public to support inheritance of Cli…
JoshLozensky Mar 14, 2023
02fe526
Merge branch 'master' into lozensky_ClientAssertionProviderBase_Inher…
JoshLozensky Mar 17, 2023
ab79af2
Fixing overridden instances of GetClientAssertion to also be public
JoshLozensky Mar 17, 2023
e162cc4
found one3
JoshLozensky Mar 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.Identity.Web.Certificateless/AzureIdentityForKubernetesClientAssertion.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public AzureIdentityForKubernetesClientAssertion(string? filePath)
/// Get the signed assertion from a file.
/// </summary>
/// <returns>The signed assertion.</returns>
internal override Task<ClientAssertion> GetClientAssertion(CancellationToken cancellationToken)
public override Task<ClientAssertion> GetClientAssertion(CancellationToken cancellationToken)
{
string signedAssertion = File.ReadAllText(_filePath);
// Compute the expiry
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Identity.Web.Certificateless/ClientAssertionProviderBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public abstract class ClientAssertionProviderBase
/// </summary>
/// <param name="cancellationToken"></param>
/// <returns></returns>
internal abstract Task<ClientAssertion> GetClientAssertion(CancellationToken cancellationToken);
public abstract Task<ClientAssertion> GetClientAssertion(CancellationToken cancellationToken);

/// <summary>
/// Client assertion.
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Identity.Web.Certificateless/ManagedIdentityClientAssertion.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public ManagedIdentityClientAssertion(string? managedIdentityClientId)
/// acquired with managed identity (certificateless).
/// </summary>
/// <returns>The signed assertion.</returns>
internal override async Task<ClientAssertion> GetClientAssertion(CancellationToken cancellationToken)
public override async Task<ClientAssertion> GetClientAssertion(CancellationToken cancellationToken)
{
var credential = new DefaultAzureCredential(new DefaultAzureCredentialOptions { ManagedIdentityClientId = _managedIdentityClientId });

Expand Down
2 changes: 1 addition & 1 deletion tests/Microsoft.Identity.Web.Test/ClientAssertionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public class TestClientAssertion : ClientAssertionProviderBase
{
private int _n = 0;

internal override Task<ClientAssertion> GetClientAssertion(CancellationToken cancellationToken)
public override Task<ClientAssertion> GetClientAssertion(CancellationToken cancellationToken)
{
_n++;
return Task.FromResult(new ClientAssertion(
Expand Down