Code optimization and FAQ update

Author: sameerag

lib/msal-browser/FAQ.md

@@ -241,7 +241,7 @@ The `authority` string that you need to supplant to MSAL app configuration is no
 
 ## What does authority string default to if I provide "authority" and "azureCloudOptions"?
 
-If the developer provides `azureCloudOptions`, we overwrite any value provided in the `authority`. We also make sure we give preference to these options provided in a `request` over what is set when the msal initializes in the `configuration`.
+If the developer provides `azureCloudOptions`, MSAL.js will overwrite any value provided in the `authority`. MSAL.js will also give preference to the parameters provided in a `request` over `configuration`. Please note that if `azureCloudOptions` are set in the configuration, they will take precedence over `authority` in the `request`. If the developer needs to overwrite this, they need to set `azureCloudOptions` in the request.
 
 ## What should I set my `redirectUri` to?
 

lib/msal-browser/src/interaction_client/StandardInteractionClient.ts

@@ -220,23 +220,13 @@ export abstract class StandardInteractionClient extends BaseInteractionClient {
             authorityMetadata: this.config.auth.authorityMetadata,
         };
 
-        // Fetch the authority from request if provided, default if the user authority is not defined
-        const userRequestedAuthority = requestAuthority ? requestAuthority : Constants.DEFAULT_AUTHORITY;
-
-        // build authority string based on auth params, precedence - azureCloudInstance + tenant >> authority and request parameters  >> config parameters
-        const generatedAuthority = requestAzureCloudOptions ?
-            Authority.generateAuthority(userRequestedAuthority, requestAzureCloudOptions) :
-            Authority.generateAuthority(userRequestedAuthority);
-
-        if (generatedAuthority) {
-            this.logger.verbose("Creating discovered authority with request authority");
-            return await AuthorityFactory.createDiscoveredInstance(generatedAuthority, this.config.system.networkClient, this.browserStorage, authorityOptions);
-        }
+        // build authority string based on auth params, precedence - azureCloudInstance + tenant >> authority
+        const userAuthority = requestAuthority ? requestAuthority : this.config.auth.authority;
 
         // fall back to the authority from config
-        const configAuthority = Authority.generateAuthority(this.config.auth.authority, this.config.auth.azureCloudOptions);
+        const builtAuthority = Authority.generateAuthority( userAuthority, requestAzureCloudOptions || this.config.auth.azureCloudOptions);
         this.logger.verbose("Creating discovered authority with configured authority");
-        return await AuthorityFactory.createDiscoveredInstance(configAuthority, this.config.system.networkClient, this.browserStorage, authorityOptions);
+        return await AuthorityFactory.createDiscoveredInstance(builtAuthority, this.config.system.networkClient, this.browserStorage, authorityOptions);
     }
 
     /**