Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Rev API plugin in the builds to catch API regressions. #817

Open
g2vinay opened this issue May 14, 2024 · 0 comments
Open

Use Rev API plugin in the builds to catch API regressions. #817

g2vinay opened this issue May 14, 2024 · 0 comments
Labels
Internal Internal enhancements to the development process, CI/CD pipelines, etc.

Comments

@g2vinay
Copy link

g2vinay commented May 14, 2024

Library version used

1.15.0

Java version

Java 11

Scenario

Other - please specify

Is this a new or an existing app?

None

Issue description and reproduction steps

Recently an API regression shipped in Msal 1.15.0 version.
Specifically

The relocation of the APIs from AbstractApplicationClientBase to AbstractApplicationBase in this PR. MSI Refactoring (#715) · AzureAD/microsoft-authentication-library-for-java@450757a (github.com)

The break is specifically the fluent return type from the Builder class, as it has now moved to AbstractApplicationBase.
MSI Refactoring (#715) · AzureAD/microsoft-authentication-library-for-java@450757a (github.com)

Using Rev API plugins in the builds will help to catch such issues.

Relevant code snippets

No response

Expected behavior

No response

Identity provider

Microsoft Entra ID (Work and School accounts and Personal Microsoft accounts)

Regression

1.15.0

Solution and workarounds

Using Rev API plugins in the builds will help to catch such issues.

@g2vinay g2vinay added needs attention Automatically used when an issue is created through an issue template untriaged Automatically used when an issue is created through an issue template labels May 14, 2024
@Avery-Dunn Avery-Dunn added Internal Internal enhancements to the development process, CI/CD pipelines, etc. and removed needs attention Automatically used when an issue is created through an issue template untriaged Automatically used when an issue is created through an issue template labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Internal enhancements to the development process, CI/CD pipelines, etc.
Projects
None yet
Development

No branches or pull requests

2 participants