Add 'haschrome=1' to avoid unexpected back buttons on the first page. #4836
+19
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://identitydivision.visualstudio.com/Engineering/_workitems/edit/2972166
Fixes #4738
Changes proposed in this request
It's very easy to reproduce (need to add login hint in the test app code first) the back button by:
In MSAL C++, interactively calls always add "haschrome=1" to avoid such kind of unexpected back buttons on the first page, and this way is also recommended by ESTS folks.
https://github.com/AzureAD/microsoft-authentication-library-for-cpp/blob/4fa774db2b38cdce9c9b94e3e686ab53fc24b948/source/xplat/requests/WebRequestManager.cpp#L566
After adding "haschrome=1" the issue can be resolved:
Testing
Performance impact
Documentation