Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Remove publishing to VSTS Feed from the build pipeline #3689

Closed
gladjohn opened this issue Sep 21, 2022 · 1 comment · Fixed by #3692
Closed

[Feature Request] Remove publishing to VSTS Feed from the build pipeline #3689

gladjohn opened this issue Sep 21, 2022 · 1 comment · Fixed by #3692
Assignees
Milestone

Comments

@gladjohn
Copy link
Contributor

gladjohn commented Sep 21, 2022

Remove publishing to VSTS Feed from the build pipeline.

Our daily pipeline is pushing all 3 packages (client, desktop and broker) to our internal IDDP feed. But when we release version it, the internal feed gets the release versioned NuGet, but we may not necessarily release the one we tagged as release. Just like nuget.org, internal feed can take only one copy of a given version, this blocks us from publishing the actual released version to the internal feed.

For 4.47.0 release we had 3 RCs, and the first RC was pushed to the internal feed. But we released RC3 to NuGet.org.

After MSAL 4.47.0 release, we had to release a 4.47.1 to fix this issue for our 1P customers (MS Internal). This bug needs to be handled on priority to avoid such issues in the future.

@gladjohn
Copy link
Contributor Author

There were couple of options suggested by @pmaytak and @trwalke

  • remove VSTS Feed completely from the build pipeline and create a VSTS feed publish pipeline
  • add publish parameter to the build pipeline, set it to false as default. Override for builds that needs to be published by adding the supplying the variable during release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants