Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Expose the region or error used by MSAL #2975

Closed
bgavrilMS opened this issue Oct 25, 2021 · 7 comments · Fixed by #3173
Closed

[Feature Request] Expose the region or error used by MSAL #2975

bgavrilMS opened this issue Oct 25, 2021 · 7 comments · Fixed by #3173

Comments

@bgavrilMS
Copy link
Member

bgavrilMS commented Oct 25, 2021

Part of AuthenticationResultMetadta, expose a string RegionOrDiscoveryError which is populated only if WithAzureRegion is used.

If region auto-detection failed, this metric should describe the reason (over and over again!)

{
AuthenticationMetadata.RegionDiscoveryOutcome -> [RegionOutcome, Exception, RegionUsed]
}

@jennyf19
Copy link
Collaborator

@bgavrilMS can this be prioritized for upcoming release?

@bgavrilMS
Copy link
Member Author

We were thinking to wrap up msal 4.38 and not start new work. Note that MSAL exposes AuthentcationResultMetadata.TokenEndpoint, which will include the region. Is this not enough?

@jennyf19
Copy link
Collaborator

I think having the entire token endpoint is not straightforward for people who don't know what they are looking for. If this is not needed, close the issue. Can you also remove the 4.38 milestone, if it won't be in that release? Thanks.

@pmaytak
Copy link
Contributor

pmaytak commented Nov 16, 2021

@bgavrilMS The amount of work should be minimal, but the clarity to users should be beneficial. I propose we take this in the next release (maybe even do a quick small one).

@bgavrilMS
Copy link
Member Author

Ok

@pmaytak pmaytak modified the milestones: 4.39.0, 4.40.0 Nov 29, 2021
@bgavrilMS bgavrilMS removed this from the 4.40.0 milestone Jan 10, 2022
@bgavrilMS bgavrilMS added this to the 4.42.0 milestone Feb 11, 2022
@bgavrilMS
Copy link
Member Author

I propose that we take this as we're getting more and more issues around auto-discovery.

@bgavrilMS bgavrilMS changed the title [Feature Request] Expose the region used by MSAL [Feature Request] Expose the region or error used by MSAL Feb 11, 2022
@bgavrilMS
Copy link
Member Author

CC @gladjohn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment