Update the msal test app for Native Auth #2143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
SammyO
reviewed
Jul 17, 2024
| // .customAttribute(attr2Key, attr2Value) | ||
| // } | ||
| val attr1Key = binding.attr1KeyText.text.toString() | ||
| if (attr1Key.isNotBlank()) { |
Contributor
There was a problem hiding this comment.
Let's not do this check. We may want to execute tests that validate whether the SDK's string check works correctly, or whether the API's string check works correctly. Same for the one below.
SammyO
reviewed
Jul 17, 2024
...app/src/main/java/com/microsoft/identity/client/testapp/nativeauth/SignUpPasswordFragment.kt
Show resolved
Hide resolved
Yuki-YuXin
approved these changes
Jul 17, 2024
SammyO
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the MSAL test app to support custom attribute test cases without the need to modify the source code.
ADO Ticket (2979358)