Skip to content
This repository has been archived by the owner on Aug 7, 2021. It is now read-only.

remove need for dynamic access to package.json to obtain lib version (util.js) #155

Closed
aappddeevv opened this issue May 2, 2017 · 5 comments · Fixed by #165
Closed

remove need for dynamic access to package.json to obtain lib version (util.js) #155

aappddeevv opened this issue May 2, 2017 · 5 comments · Fixed by #165

Comments

@aappddeevv
Copy link

aappddeevv commented May 2, 2017

When trying to add node-adal into a larger bundle, the runtime dependency on a package.json causes bundling schemes motivate a runtime failure since the package.json cannot be accessed from the larger bundle.

@akos-sebestyen
Copy link
Contributor

👍 Please!

@morrisjn
Copy link

I would also love this fix! Thank you.

@tomflenniken
Copy link

tomflenniken commented Aug 23, 2017

The recommended approach for Azure functions is to webpack the deployed files (see https://github.com/Azure/azure-functions-pack). Adal-node is incompatible with this approach and requires us to include the adal-node packages as a separate node_module. This causes significant performance degradation (cold start times go from 5-7 seconds to ~30).
Azure/azure-functions-host#298

@akos-sebestyen
Copy link
Contributor

@tomflenniken we had the exact same issue. See this workaround.
#165

@lovemaths
Copy link
Contributor

@akos-sebestyen Thank you for your PR, we will do a new release this week with your PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants