Skip to content

Remove TransformBeforeSignatureValidationDelegate from ValidationParameters #2848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Remove TransformBeforeSignatureValidationDelegate from ValidationParameters #2848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fd4cc4
Removed TransformBeforeSignatureValidationDelegate from ValidationPar…
iNinja Sep 26, 2024
51c3be9
Removed delegate definition
iNinja Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/Microsoft.IdentityModel.Tokens/Delegates.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,13 +205,5 @@ namespace Microsoft.IdentityModel.Tokens
/// <remarks>This method is not expected to throw.</remarks>
/// <returns>The validated <see cref="SecurityToken"/>.</returns>
internal delegate ValidationResult<SecurityKey> SignatureValidationDelegate(SecurityToken token, ValidationParameters validationParameters, BaseConfiguration? configuration, CallContext? callContext);

/// <summary>
/// Transforms the security token before signature validation.
/// </summary>
/// <param name="token">The <see cref="SecurityToken"/> being validated.</param>
/// <param name="validationParameters">The <see cref="ValidationParameters"/> to be used for validating the token.</param>
/// <returns>The transformed <see cref="SecurityToken"/>.</returns>
internal delegate SecurityToken TransformBeforeSignatureValidationDelegate(SecurityToken token, ValidationParameters validationParameters);
#nullable restore
}
6 changes: 0 additions & 6 deletions src/Microsoft.IdentityModel.Tokens/Validation/ValidationParameters.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ protected ValidationParameters(ValidationParameters other)
TokenDecryptionKeys = other.TokenDecryptionKeys;
TokenReplayCache = other.TokenReplayCache;
TokenReplayValidator = other.TokenReplayValidator;
TransformBeforeSignatureValidation = other.TransformBeforeSignatureValidation;
TypeValidator = other.TypeValidator;
ValidateActor = other.ValidateActor;
ValidateSignatureLast = other.ValidateSignatureLast;
Expand Down Expand Up @@ -319,11 +318,6 @@ public IssuerValidationDelegateAsync IssuerValidatorAsync
set { _issuerValidatorAsync = value ?? throw new ArgumentNullException(nameof(value), "IssuerValidatorAsync cannot be set as null."); }
}

/// <summary>
/// Gets or sets a delegate that will be called to transform a token to a supported format before validation.
/// </summary>
public TransformBeforeSignatureValidationDelegate TransformBeforeSignatureValidation { get; set; }

/// <summary>
/// Allows overriding the delegate that will be used to validate the lifetime of the token
/// </summary>
Expand Down