Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource type has key property same with the parent #56

Closed
Tracked by #72
tadelesh opened this issue Dec 25, 2023 · 2 comments
Closed
Tracked by #72

Resource type has key property same with the parent #56

tadelesh opened this issue Dec 25, 2023 · 2 comments
Labels
external:mgmt external:swagger-converter Issues related to the swagger-converter tool needs-area

Comments

@tadelesh
Copy link
Member

tadelesh commented Dec 25, 2023

Example: Resource type 'ProvisionedCluster' has a key property named 'default' which conflicts with the key name of a parent or child
This is happening as we have 2 'default' in few of our API paths. For example: {connectedClusterResourceUri}/providers/Microsoft.HybridContainerService/provisionedClusterInstances/default/upgradeProfiles/default.

@tadelesh tadelesh added the ARM label Dec 25, 2023
@ArthurMa1978 ArthurMa1978 changed the title Resource type has key property same with the parent [P0] Resource type has key property same with the parent Jan 3, 2024
@ArthurMa1978 ArthurMa1978 added the external:swagger-converter Issues related to the swagger-converter tool label Jan 3, 2024
@ArthurMa1978 ArthurMa1978 changed the title [P0] Resource type has key property same with the parent Resource type has key property same with the parent Jan 3, 2024
@markcowl
Copy link
Member

markcowl commented Jan 5, 2024

@tadelesh This is not conflict, it is a parent singleton resource with a child that is also a singleton. Here is a sample of how this pattern should be modeled

@markcowl
Copy link
Member

markcowl commented Jan 8, 2024

Closing as fixed, please reopen if there are additional issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external:mgmt external:swagger-converter Issues related to the swagger-converter tool needs-area
Projects
None yet
Development

No branches or pull requests

3 participants