Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][TCGC]: SdkEnumValueType.valueType should be SdkBuiltInType #541

Closed
4 tasks done
archerzz opened this issue Mar 28, 2024 · 0 comments · Fixed by #517
Closed
4 tasks done

[Bug][TCGC]: SdkEnumValueType.valueType should be SdkBuiltInType #541

archerzz opened this issue Mar 28, 2024 · 0 comments · Fixed by #517
Assignees
Labels
bug Something isn't working lib:tcgc Issues for @azure-tools/typespec-client-generator-core library needs-area

Comments

@archerzz
Copy link
Member

archerzz commented Mar 28, 2024

Describe the bug

SdkEnumValueType.valueType is SdkType:

which seems too generic. It should be SdkBuiltInType, like SdkConstantType.valueType:

Reproduction

Just check the source code link above.

Checklist

  • Follow our Code of Conduct
  • Check that this issue is about the Azure libraries for typespec. For bug in the typespec language or core libraries file it in the TypeSpec repo
  • Check that there isn't already an issue that request the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@archerzz archerzz added the bug Something isn't working label Mar 28, 2024
@archerzz archerzz added the lib:tcgc Issues for @azure-tools/typespec-client-generator-core library label Mar 28, 2024
@tadelesh tadelesh self-assigned this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lib:tcgc Issues for @azure-tools/typespec-client-generator-core library needs-area
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants