[Bug][TCGC] Multiple instances of OperationStatus model definition

[archerzz]

Describe the bug
This is a successor of #204 After fixing it, OperationStatus appears in the context.modelsMap. However, it seems that the OperationStatus instance in context.modelsMap is NOT the same as the one returned in getLroMetadata. So codes like below won't work:

 function getInputModelForModel(m: Model): InputModelType | undefined {
    if (context.modelsMap!.has(m)) { // won't work because `m` is a different instance then the one in `modelsMap`.
       ...
 }

To Reproduce

• Try to parse the lro operation like the one in

  typespec-azure/packages/typespec-client-generator-core/test/public-utils.test.ts

  Line 1377 in de0ebda

  describe("getLroMetadata", () => {

  .
• Check the OperationStatus instances from getLroMetadata and context.modelsMap

Expected behavior
OperationStatus instance should be globally unique.

Additional context

Not sure if it's related to how OperationStatus is fetched inside getLroMetadata. I tried to debug, and it's from getResourceLocationType:

typespec-azure/packages/typespec-azure-core/src/lro-helpers.ts

Line 1113 in de0ebda

return getResourceLocationType(program, resolvedScalar);

which is: https://github.com/microsoft/typespec/blob/8c7c76bf8e17e9ab2ad5a8bab6c3a8ba2d125de3/packages/rest/src/rest.ts#L562

[archerzz]

After debugging, I think the problem is not because of there are multiple instance of the same OperationStatus. It's because of the metadata parsed by getLroMetadata() is different from what TCGC parsed.

The above is the OperationStaus parsed by getLroMetadata(). As you can see, it's name is OperationStatus.

This is what the corresponding metadata in TCGC. Its name is ResourceOperationStatus, and its sourceModel property is the same as the one parsed by getLroMetadata.

ResourceOperationStatus is a OperationStatus:

typespec-azure/packages/typespec-azure-core/lib/models.tsp

Lines 48 to 54 in 4b26297

	@resource("operations")
	@parentResource(Resource)
	model ResourceOperationStatus<
	Resource extends TypeSpec.Reflection.Model,
	StatusResult = Resource,
	StatusError = Foundations.Error
	> is Azure.Core.Foundations.OperationStatus<StatusResult, StatusError>;

Now the problem is how we get the two different sybmols.

[tadelesh]

The root cause should be #311 (comment)

[iscai-msft]

Switching to envelopeResult should've fixed the issue, @archerzz I'm going to close this issue, if it's still an issue, can you reopen? Thank you!