From b02eabc8eacf25c2eceadf7290578ecd7669c4e6 Mon Sep 17 00:00:00 2001 From: Chenjie Shi Date: Thu, 15 Aug 2024 14:33:37 +0800 Subject: [PATCH] [tcgc] no need to add access override along with usage override for orphan model (#1378) this should be a bug that missing in https://github.com/Azure/typespec-azure/pull/925. since we changed access default to public, we no longer need to add access override along with usage override when we want to expose an orphan model --- .../changes/fix_usage-2024-7-15-13-21-20.md | 7 +++++ .../src/types.ts | 6 ++-- .../test/decorators.test.ts | 2 -- .../test/public-utils.test.ts | 2 -- .../types/body-model-property-types.test.ts | 7 ----- .../test/types/built-in-types.test.ts | 18 ------------ .../test/types/constant-types.test.ts | 3 -- .../test/types/date-time-types.test.ts | 8 ------ .../test/types/duration-type.test.ts | 6 ---- .../test/types/enum-types.test.ts | 18 ------------ .../test/types/model-types.test.ts | 15 ---------- .../test/types/multipart-types.test.ts | 1 - .../test/types/tuple-types.test.ts | 1 - .../test/types/union-types.test.ts | 28 ------------------- 14 files changed, 9 insertions(+), 113 deletions(-) create mode 100644 .chronus/changes/fix_usage-2024-7-15-13-21-20.md diff --git a/.chronus/changes/fix_usage-2024-7-15-13-21-20.md b/.chronus/changes/fix_usage-2024-7-15-13-21-20.md new file mode 100644 index 0000000000..531b4c2b1a --- /dev/null +++ b/.chronus/changes/fix_usage-2024-7-15-13-21-20.md @@ -0,0 +1,7 @@ +--- +changeKind: fix +packages: + - "@azure-tools/typespec-client-generator-core" +--- + +no need to add access override along with usage override for orphan model \ No newline at end of file diff --git a/packages/typespec-client-generator-core/src/types.ts b/packages/typespec-client-generator-core/src/types.ts index 1f3c92a202..dddcae2b00 100644 --- a/packages/typespec-client-generator-core/src/types.ts +++ b/packages/typespec-client-generator-core/src/types.ts @@ -1709,10 +1709,8 @@ function handleServiceOrphanType(context: TCGCContext, type: Model | Enum | Unio const sdkType = diagnostics.pipe(getClientTypeWithDiagnostics(context, type)); updateUsageOfModel(context, UsageFlags.Input | UsageFlags.Output, sdkType); } - if (getAccessOverride(context, type) !== undefined) { - const sdkType = diagnostics.pipe(getClientTypeWithDiagnostics(context, type)); - updateUsageOfModel(context, UsageFlags.None, sdkType); - } + const sdkType = diagnostics.pipe(getClientTypeWithDiagnostics(context, type)); + updateUsageOfModel(context, UsageFlags.None, sdkType); } function verifyNoConflictingMultipartModelUsage( diff --git a/packages/typespec-client-generator-core/test/decorators.test.ts b/packages/typespec-client-generator-core/test/decorators.test.ts index f479d428fe..f97d102f2d 100644 --- a/packages/typespec-client-generator-core/test/decorators.test.ts +++ b/packages/typespec-client-generator-core/test/decorators.test.ts @@ -2328,7 +2328,6 @@ describe("typespec-client-generator-core: decorators", () => { @test namespace MyService { @test @usage(Usage.input | Usage.output) - @access(Access.public) enum Enum1{ one, two, @@ -2344,7 +2343,6 @@ describe("typespec-client-generator-core: decorators", () => { @test @usage(Usage.input | Usage.output) - @access(Access.public) model Model1{ prop: string } @test diff --git a/packages/typespec-client-generator-core/test/public-utils.test.ts b/packages/typespec-client-generator-core/test/public-utils.test.ts index fab7935ead..6d30073c5e 100644 --- a/packages/typespec-client-generator-core/test/public-utils.test.ts +++ b/packages/typespec-client-generator-core/test/public-utils.test.ts @@ -1517,7 +1517,6 @@ describe("typespec-client-generator-core: public-utils", () => { await runner.compileWithBuiltInService( ` @usage(Usage.input | Usage.output) - @access(Access.public) model A { pForA: { name: string; @@ -1545,7 +1544,6 @@ describe("typespec-client-generator-core: public-utils", () => { await runner.compileWithBuiltInService( ` @usage(Usage.input | Usage.output) - @access(Access.public) model A { status: "start" | "stop"; } diff --git a/packages/typespec-client-generator-core/test/types/body-model-property-types.test.ts b/packages/typespec-client-generator-core/test/types/body-model-property-types.test.ts index de7683a30e..2ad49efa50 100644 --- a/packages/typespec-client-generator-core/test/types/body-model-property-types.test.ts +++ b/packages/typespec-client-generator-core/test/types/body-model-property-types.test.ts @@ -15,7 +15,6 @@ describe("typespec-client-generator-core: body model property types", () => { it("required", async function () { await runner.compileWithBuiltInService(` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { name: string | int32; } @@ -27,7 +26,6 @@ describe("typespec-client-generator-core: body model property types", () => { it("optional", async function () { await runner.compileWithBuiltInService(` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { name?: string; } @@ -39,7 +37,6 @@ describe("typespec-client-generator-core: body model property types", () => { it("readonly", async function () { await runner.compileWithBuiltInService(` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { @visibility("read") name?: string; @@ -52,7 +49,6 @@ describe("typespec-client-generator-core: body model property types", () => { it("not readonly", async function () { await runner.compileWithBuiltInService(` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { @visibility("read", "create", "update") name?: string; @@ -67,7 +63,6 @@ describe("typespec-client-generator-core: body model property types", () => { #suppress "deprecated" "for testing" @test @usage(Usage.input | Usage.output) - @access(Access.public) @projectedName("java", "JavaTest") model Test { @projectedName("java", "javaProjectedName") @@ -125,7 +120,6 @@ describe("typespec-client-generator-core: body model property types", () => { it("union type", async function () { await runner.compileWithBuiltInService(` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { name: string | int32; } @@ -159,7 +153,6 @@ describe("typespec-client-generator-core: body model property types", () => { } @usage(Usage.input | Usage.output) - @access(Access.public) model Test { @added(Versions.v1) @removed(Versions.v2) diff --git a/packages/typespec-client-generator-core/test/types/built-in-types.test.ts b/packages/typespec-client-generator-core/test/types/built-in-types.test.ts index 7a02e6e965..df986bb75d 100644 --- a/packages/typespec-client-generator-core/test/types/built-in-types.test.ts +++ b/packages/typespec-client-generator-core/test/types/built-in-types.test.ts @@ -19,7 +19,6 @@ describe("typespec-client-generator-core: built-in types", () => { await runner.compileWithBuiltInService( ` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { prop: string; } @@ -35,7 +34,6 @@ describe("typespec-client-generator-core: built-in types", () => { await runner.compileWithBuiltInService( ` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { prop: boolean; } @@ -63,7 +61,6 @@ describe("typespec-client-generator-core: built-in types", () => { await runner.compileWithBuiltInService( ` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { prop: ${type}; } @@ -82,7 +79,6 @@ describe("typespec-client-generator-core: built-in types", () => { await runner.compileWithBuiltInService( ` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { prop: ${type}; } @@ -99,7 +95,6 @@ describe("typespec-client-generator-core: built-in types", () => { await runner.compileWithBuiltInService( ` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { prop: decimal; } @@ -115,7 +110,6 @@ describe("typespec-client-generator-core: built-in types", () => { await runner.compileWithBuiltInService( ` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { prop: decimal128; } @@ -131,7 +125,6 @@ describe("typespec-client-generator-core: built-in types", () => { await runner.compileWithBuiltInService( ` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { prop: unknown; } @@ -145,7 +138,6 @@ describe("typespec-client-generator-core: built-in types", () => { await runner.compileWithBuiltInService( ` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { prop: bytes; } @@ -161,7 +153,6 @@ describe("typespec-client-generator-core: built-in types", () => { await runner.compileWithBuiltInService( ` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { @encode(BytesKnownEncoding.base64) prop: bytes; @@ -178,7 +169,6 @@ describe("typespec-client-generator-core: built-in types", () => { await runner.compileWithBuiltInService( ` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { @encode(BytesKnownEncoding.base64url) prop: bytes; @@ -198,7 +188,6 @@ describe("typespec-client-generator-core: built-in types", () => { scalar Base64UrlBytes extends bytes; @usage(Usage.input | Usage.output) - @access(Access.public) model Test { value: Base64UrlBytes[]; } @@ -224,7 +213,6 @@ describe("typespec-client-generator-core: built-in types", () => { await runnerWithCore.compileWithBuiltInAzureCoreService( ` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { id: Azure.Core.armResourceIdentifier<[ { @@ -251,7 +239,6 @@ describe("typespec-client-generator-core: built-in types", () => { await runnerWithCore.compileWithBuiltInAzureCoreService( ` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { urlScalar: url; @@ -313,7 +300,6 @@ describe("typespec-client-generator-core: built-in types", () => { scalar Derived extends Base; @usage(Usage.input | Usage.output) - @access(Access.public) model Test { prop: Derived; } @@ -338,7 +324,6 @@ describe("typespec-client-generator-core: built-in types", () => { await runner.compileWithBuiltInService( ` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { @format("unknown") unknownProp: string; @@ -402,7 +387,6 @@ describe("typespec-client-generator-core: built-in types", () => { scalar TestScalar extends string; @usage(Usage.input | Usage.output) - @access(Access.public) model Test { prop: TestScalar; } @@ -422,7 +406,6 @@ describe("typespec-client-generator-core: built-in types", () => { await runner.compileWithBuiltInService( ` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { @encode(string) value: safeint; @@ -442,7 +425,6 @@ describe("typespec-client-generator-core: built-in types", () => { scalar int32EncodedAsString extends int32; @usage(Usage.input | Usage.output) - @access(Access.public) model Test { value: int32EncodedAsString; } diff --git a/packages/typespec-client-generator-core/test/types/constant-types.test.ts b/packages/typespec-client-generator-core/test/types/constant-types.test.ts index c982af6fd7..2ec2976bcf 100644 --- a/packages/typespec-client-generator-core/test/types/constant-types.test.ts +++ b/packages/typespec-client-generator-core/test/types/constant-types.test.ts @@ -13,7 +13,6 @@ describe("typespec-client-generator-core: constant types", () => { it("string", async function () { await runner.compileWithBuiltInService(` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { prop: "json"; } @@ -29,7 +28,6 @@ describe("typespec-client-generator-core: constant types", () => { it("boolean", async function () { await runner.compileWithBuiltInService(` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { @test prop: true; } @@ -45,7 +43,6 @@ describe("typespec-client-generator-core: constant types", () => { it("number", async function () { await runner.compileWithBuiltInService(` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { @test prop: 4; } diff --git a/packages/typespec-client-generator-core/test/types/date-time-types.test.ts b/packages/typespec-client-generator-core/test/types/date-time-types.test.ts index 008a67c3e9..e2aadb482a 100644 --- a/packages/typespec-client-generator-core/test/types/date-time-types.test.ts +++ b/packages/typespec-client-generator-core/test/types/date-time-types.test.ts @@ -14,7 +14,6 @@ describe("typespec-client-generator-core: date-time types", () => { await runner.compileWithBuiltInService( ` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { prop: utcDateTime; } @@ -30,7 +29,6 @@ describe("typespec-client-generator-core: date-time types", () => { await runner.compileWithBuiltInService( ` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { @encode(DateTimeKnownEncoding.rfc3339) prop: utcDateTime; @@ -47,7 +45,6 @@ describe("typespec-client-generator-core: date-time types", () => { await runner.compileWithBuiltInService( ` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { @encode(DateTimeKnownEncoding.rfc7231) prop: utcDateTime; @@ -65,7 +62,6 @@ describe("typespec-client-generator-core: date-time types", () => { await runner.compileWithBuiltInService( ` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { prop: unixTimestamp32; } @@ -83,7 +79,6 @@ describe("typespec-client-generator-core: date-time types", () => { await runner.compileWithBuiltInService( ` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { @encode(DateTimeKnownEncoding.unixTimestamp, int64) value: utcDateTime; @@ -107,7 +102,6 @@ describe("typespec-client-generator-core: date-time types", () => { scalar extraLayerDateTime extends unixTimestampDatetime; @usage(Usage.input | Usage.output) - @access(Access.public) model Test { value: extraLayerDateTime; } @@ -135,7 +129,6 @@ describe("typespec-client-generator-core: date-time types", () => { await runner.compileWithBuiltInService( ` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { @encode(DateTimeKnownEncoding.unixTimestamp, int64) value: utcDateTime | null; @@ -160,7 +153,6 @@ describe("typespec-client-generator-core: date-time types", () => { scalar unixTimestampDateTime extends utcDateTime; @usage(Usage.input | Usage.output) - @access(Access.public) model Test { value: unixTimestampDateTime[]; } diff --git a/packages/typespec-client-generator-core/test/types/duration-type.test.ts b/packages/typespec-client-generator-core/test/types/duration-type.test.ts index 43ab0a4e2c..90ca69ab52 100644 --- a/packages/typespec-client-generator-core/test/types/duration-type.test.ts +++ b/packages/typespec-client-generator-core/test/types/duration-type.test.ts @@ -14,7 +14,6 @@ describe("typespec-client-generator-core: duration types", () => { await runner.compileWithBuiltInService( ` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { prop: duration; } @@ -29,7 +28,6 @@ describe("typespec-client-generator-core: duration types", () => { await runner.compileWithBuiltInService( ` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { @encode(DurationKnownEncoding.ISO8601) prop: duration; @@ -46,7 +44,6 @@ describe("typespec-client-generator-core: duration types", () => { await runner.compileWithBuiltInService( ` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { @encode(DurationKnownEncoding.seconds, int32) prop: duration; @@ -63,7 +60,6 @@ describe("typespec-client-generator-core: duration types", () => { await runner.compileWithBuiltInService( ` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { @encode(DurationKnownEncoding.seconds, float) prop: duration; @@ -80,7 +76,6 @@ describe("typespec-client-generator-core: duration types", () => { await runner.compileWithBuiltInService( ` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { @encode(DurationKnownEncoding.seconds, float) prop: duration | null; @@ -105,7 +100,6 @@ describe("typespec-client-generator-core: duration types", () => { scalar Float32Duration extends duration; @usage(Usage.input | Usage.output) - @access(Access.public) model Test { value: Float32Duration[]; } diff --git a/packages/typespec-client-generator-core/test/types/enum-types.test.ts b/packages/typespec-client-generator-core/test/types/enum-types.test.ts index 96c1c76c06..c2ffcc4b42 100644 --- a/packages/typespec-client-generator-core/test/types/enum-types.test.ts +++ b/packages/typespec-client-generator-core/test/types/enum-types.test.ts @@ -20,7 +20,6 @@ describe("typespec-client-generator-core: enum types", () => { it("string extensible", async function () { await runner.compileWithBuiltInService(` @usage(Usage.input | Usage.output) - @access(Access.public) enum DaysOfWeekExtensibleEnum { Monday, Tuesday, @@ -32,7 +31,6 @@ describe("typespec-client-generator-core: enum types", () => { } @usage(Usage.input | Usage.output) - @access(Access.public) model Test { prop: DaysOfWeekExtensibleEnum } @@ -67,7 +65,6 @@ describe("typespec-client-generator-core: enum types", () => { it("int extensible", async function () { await runner.compileWithBuiltInService(` @usage(Usage.input | Usage.output) - @access(Access.public) enum Integers { one: 1, two: 2, @@ -77,7 +74,6 @@ describe("typespec-client-generator-core: enum types", () => { } @usage(Usage.input | Usage.output) - @access(Access.public) model Test { prop: Integers } @@ -105,7 +101,6 @@ describe("typespec-client-generator-core: enum types", () => { it("float extensible", async function () { await runner.compileWithBuiltInService(` @usage(Usage.input | Usage.output) - @access(Access.public) enum Floats { a: 1, b: 2.1, @@ -113,7 +108,6 @@ describe("typespec-client-generator-core: enum types", () => { } @usage(Usage.input | Usage.output) - @access(Access.public) model Test { prop: Floats } @@ -140,7 +134,6 @@ describe("typespec-client-generator-core: enum types", () => { it("union as enum float type", async function () { await runner.compileWithBuiltInService(` @usage(Usage.input | Usage.output) - @access(Access.public) union Floats { float, a: 1, @@ -149,7 +142,6 @@ describe("typespec-client-generator-core: enum types", () => { } @usage(Usage.input | Usage.output) - @access(Access.public) model Test { prop: Floats } @@ -175,14 +167,12 @@ describe("typespec-client-generator-core: enum types", () => { it("union of union as enum float type", async function () { await runner.compileWithBuiltInService(` @usage(Usage.input | Usage.output) - @access(Access.public) union BaseEnum { int32, a: 1, } @usage(Usage.input | Usage.output) - @access(Access.public) union ExtendedEnum { BaseEnum, b: 2, @@ -190,7 +180,6 @@ describe("typespec-client-generator-core: enum types", () => { } @usage(Usage.input | Usage.output) - @access(Access.public) model Test { prop: ExtendedEnum } @@ -221,7 +210,6 @@ describe("typespec-client-generator-core: enum types", () => { @doc(".") @fixed @usage(Usage.input | Usage.output) - @access(Access.public) enum DaysOfWeekFixedEnum { @doc("Monday") Monday, @doc("Tuesday") Tuesday, @@ -234,7 +222,6 @@ describe("typespec-client-generator-core: enum types", () => { @doc(".") @usage(Usage.input | Usage.output) - @access(Access.public) model Test { @doc(".") prop: DaysOfWeekFixedEnum @@ -287,7 +274,6 @@ describe("typespec-client-generator-core: enum types", () => { @service({}) namespace MyService { @usage(Usage.input | Usage.output) - @access(Access.public) enum Integers { one: 1, two: 2, @@ -297,7 +283,6 @@ describe("typespec-client-generator-core: enum types", () => { } @usage(Usage.input | Usage.output) - @access(Access.public) model Test { prop: Integers } @@ -330,7 +315,6 @@ describe("typespec-client-generator-core: enum types", () => { @test namespace MyService { @test @usage(Usage.input | Usage.output) - @access(Access.public) enum Enum1{ one, two, @@ -355,7 +339,6 @@ describe("typespec-client-generator-core: enum types", () => { @test namespace MyService { @test @usage(Usage.input | Usage.output) - @access(Access.public) @projectedName("java", "JavaEnum1") enum Enum1{ @projectedName("java", "JavaOne") @@ -374,7 +357,6 @@ describe("typespec-client-generator-core: enum types", () => { #suppress "deprecated" "for testing" @test @usage(Usage.input | Usage.output) - @access(Access.public) @projectedName("java", "JavaEnum1") enum Enum1{ #suppress "deprecated" "for testing" diff --git a/packages/typespec-client-generator-core/test/types/model-types.test.ts b/packages/typespec-client-generator-core/test/types/model-types.test.ts index 177976849c..ffde0adf06 100644 --- a/packages/typespec-client-generator-core/test/types/model-types.test.ts +++ b/packages/typespec-client-generator-core/test/types/model-types.test.ts @@ -132,7 +132,6 @@ describe("typespec-client-generator-core: model types", () => { it("recursive model", async () => { await runner.compileWithBuiltInService(` @usage(Usage.input | Usage.output) - @access(Access.public) model RecursiveModel { prop: RecursiveModel } @@ -1113,23 +1112,19 @@ describe("typespec-client-generator-core: model types", () => { it("additionalProperties of same type", async () => { await runner.compileWithBuiltInService(` @usage(Usage.input | Usage.output) - @access(Access.public) model AdditionalPropertiesModel extends Record { prop: string; } @usage(Usage.input | Usage.output) - @access(Access.public) model AdditionalPropertiesModel2 is Record { prop: string; } @usage(Usage.input | Usage.output) - @access(Access.public) model AdditionalPropertiesModel3 { prop: string; ...Record; } @usage(Usage.input | Usage.output) - @access(Access.public) model NoAdditionalPropertiesModel { prop: string; } @@ -1217,14 +1212,12 @@ describe("typespec-client-generator-core: model types", () => { it("additionalProperties of different types", async () => { await runner.compileWithBuiltInService(` @usage(Usage.input | Usage.output) - @access(Access.public) model AdditionalPropertiesModel { prop: string; ...Record; } @usage(Usage.input | Usage.output) - @access(Access.public) model AdditionalPropertiesModel2 { prop: string; ...Record; @@ -1248,11 +1241,9 @@ describe("typespec-client-generator-core: model types", () => { @service({}) namespace MyService { @usage(Usage.input) - @access(Access.public) model InputModel {} @usage(Usage.output) - @access(Access.public) model OutputModel {} } `); @@ -1269,7 +1260,6 @@ describe("typespec-client-generator-core: model types", () => { it("template model", async () => { await runner.compileWithBuiltInService(` @usage(Usage.input | Usage.output) - @access(Access.public) model Catalog is TrackedResource { @pattern("^[A-Za-z0-9_-]{1,50}$") @key("catalogName") @@ -1278,7 +1268,6 @@ describe("typespec-client-generator-core: model types", () => { } @usage(Usage.input | Usage.output) - @access(Access.public) model CatalogProperties { test?: string; } @@ -1288,7 +1277,6 @@ describe("typespec-client-generator-core: model types", () => { } @usage(Usage.input | Usage.output) - @access(Access.public) model Deployment is TrackedResource { @key("deploymentName") @segment("deployments") @@ -1296,7 +1284,6 @@ describe("typespec-client-generator-core: model types", () => { } @usage(Usage.input | Usage.output) - @access(Access.public) model DeploymentProperties { deploymentId?: string; deploymentDateUtc?: utcDateTime; @@ -1333,7 +1320,6 @@ describe("typespec-client-generator-core: model types", () => { @test namespace MyService { @test @usage(Usage.input | Usage.output) - @access(Access.public) model Model1{} model Model2{} @@ -1455,7 +1441,6 @@ describe("typespec-client-generator-core: model types", () => { @test namespace MyService { @test @usage(Usage.input | Usage.output) - @access(Access.public) model Test{ prop1: never; prop2: void; diff --git a/packages/typespec-client-generator-core/test/types/multipart-types.test.ts b/packages/typespec-client-generator-core/test/types/multipart-types.test.ts index 8bddd65588..b2a8f4141a 100644 --- a/packages/typespec-client-generator-core/test/types/multipart-types.test.ts +++ b/packages/typespec-client-generator-core/test/types/multipart-types.test.ts @@ -115,7 +115,6 @@ describe("typespec-client-generator-core: multipart types", () => { } @usage(Usage.input | Usage.output) - @access(Access.public) model AddressSecondAppearance { address: Address; } diff --git a/packages/typespec-client-generator-core/test/types/tuple-types.test.ts b/packages/typespec-client-generator-core/test/types/tuple-types.test.ts index 1af253d2ae..81e0e03379 100644 --- a/packages/typespec-client-generator-core/test/types/tuple-types.test.ts +++ b/packages/typespec-client-generator-core/test/types/tuple-types.test.ts @@ -14,7 +14,6 @@ describe("typespec-client-generator-core: tuple types", () => { @service({}) namespace MyService; @usage(Usage.input | Usage.output) - @access(Access.public) model MyFlow { scopes: ["https://security.microsoft.com/.default"]; test: [int32, string] diff --git a/packages/typespec-client-generator-core/test/types/union-types.test.ts b/packages/typespec-client-generator-core/test/types/union-types.test.ts index 0f9c04fc6b..b86da40b41 100644 --- a/packages/typespec-client-generator-core/test/types/union-types.test.ts +++ b/packages/typespec-client-generator-core/test/types/union-types.test.ts @@ -15,7 +15,6 @@ describe("typespec-client-generator-core: union types", () => { await runner.compileWithBuiltInService( ` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { name: string | int32; } @@ -33,7 +32,6 @@ describe("typespec-client-generator-core: union types", () => { it("nullable", async function () { await runner.compileWithBuiltInService(` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { name: float32 | null; } @@ -49,7 +47,6 @@ describe("typespec-client-generator-core: union types", () => { it("nullable with more types", async function () { await runner.compileWithBuiltInService(` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { name: string | float32 | null; } @@ -68,7 +65,6 @@ describe("typespec-client-generator-core: union types", () => { it("record with nullable", async function () { await runner.compileWithBuiltInService(` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { name: Record; } @@ -84,7 +80,6 @@ describe("typespec-client-generator-core: union types", () => { it("record with nullable with more types", async function () { await runner.compileWithBuiltInService(` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { name: Record; } @@ -105,7 +100,6 @@ describe("typespec-client-generator-core: union types", () => { it("array with nullable", async function () { await runner.compileWithBuiltInService(` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { name: (float32 | null)[]; } @@ -121,7 +115,6 @@ describe("typespec-client-generator-core: union types", () => { it("array with nullable with more types", async function () { await runner.compileWithBuiltInService(` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { name: (string | float32 | null)[]; } @@ -141,19 +134,16 @@ describe("typespec-client-generator-core: union types", () => { it("additional property is nullable", async function () { await runner.compileWithBuiltInService(` @usage(Usage.input | Usage.output) - @access(Access.public) model TestExtends extends Record { name: string; } @usage(Usage.input | Usage.output) - @access(Access.public) model TestIs is Record { name: string; } @usage(Usage.input | Usage.output) - @access(Access.public) model TestSpread { name: string; ...Record @@ -191,19 +181,16 @@ describe("typespec-client-generator-core: union types", () => { it("additional property nullable with more types", async function () { await runner.compileWithBuiltInService(` @usage(Usage.input | Usage.output) - @access(Access.public) model TestExtends extends Record { name: string; } @usage(Usage.input | Usage.output) - @access(Access.public) model TestIs is Record { name: string; } @usage(Usage.input | Usage.output) - @access(Access.public) model TestSpread { name: string; ...Record @@ -263,7 +250,6 @@ describe("typespec-client-generator-core: union types", () => { it("model with simple union property", async function () { await runner.compileWithBuiltInService(` @usage(Usage.input | Usage.output) - @access(Access.public) model ModelWithSimpleUnionProperty { prop: int32 | int32[]; } @@ -283,29 +269,24 @@ describe("typespec-client-generator-core: union types", () => { it("model with named union", async function () { await runner.compileWithBuiltInService(` @usage(Usage.input | Usage.output) - @access(Access.public) model BaseModel { name: string; } @usage(Usage.input | Usage.output) - @access(Access.public) model Model1 extends BaseModel { prop1: int32; } @usage(Usage.input | Usage.output) - @access(Access.public) model Model2 extends BaseModel { prop2: int32; } @usage(Usage.input | Usage.output) - @access(Access.public) union MyNamedUnion { one: Model1, two: Model2, } @usage(Usage.input | Usage.output) - @access(Access.public) model ModelWithNamedUnionProperty { prop: MyNamedUnion; } @@ -344,7 +325,6 @@ describe("typespec-client-generator-core: union types", () => { dog, cat, bird } @usage(Usage.input | Usage.output) - @access(Access.public) model Home { pet: PetKind | null; } @@ -365,7 +345,6 @@ describe("typespec-client-generator-core: union types", () => { it("model with nullable union as enum", async function () { await runner.compileWithBuiltInService(` @usage(Usage.input | Usage.output) - @access(Access.public) model Home { pet: "dog" | "cat" | "bird" | string | null; } @@ -386,13 +365,11 @@ describe("typespec-client-generator-core: union types", () => { it("model with nullable model property", async function () { await runner.compileWithBuiltInService(` @usage(Usage.input | Usage.output) - @access(Access.public) model PropertyModel { internalProp: string; } @usage(Usage.input | Usage.output) - @access(Access.public) model Test { prop: PropertyModel | null; } @@ -413,19 +390,16 @@ describe("typespec-client-generator-core: union types", () => { it("mix types", async function () { await runner.compileWithBuiltInService(` @usage(Usage.input | Usage.output) - @access(Access.public) model ModelType { name: string; } @usage(Usage.input | Usage.output) - @access(Access.public) model Test { prop: "none" | "auto" | ModelType; } @usage(Usage.input | Usage.output) - @access(Access.public) model TestNullable { prop: "none" | "auto" | ModelType | null; } @@ -556,7 +530,6 @@ describe("typespec-client-generator-core: union types", () => { it("usage override for orphan union as enum", async function () { await runner.compileWithBuiltInService(` @usage(Usage.input | Usage.output) - @access(Access.public) union UnionAsEnum { "A", "B", @@ -588,7 +561,6 @@ describe("typespec-client-generator-core: union types", () => { await runner.compileWithBuiltInService( ` @usage(Usage.input | Usage.output) - @access(Access.public) model Test { name: TestUnion; }