Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new connectivity capabilities #558

Merged
merged 10 commits into from
Dec 16, 2022

Conversation

krowlandson
Copy link
Contributor

@krowlandson krowlandson commented Dec 14, 2022

Overview/Summary

This PR includes fixes for a number of recent issues, as listed below.

This PR fixes/adds/changes/removes

  1. Fixes Feature Request - vwan hub connections - Internet_Security_Enabled should be a variable. #491
  2. Fixes Bug Report - enable_private_dns_zone_virtual_network_link_on_hubs = true failing on disabled hub #542
  3. Fixes Feature Request: Deploy private dns zones and link them to an existing vnet #549
  4. Fixes previously unidentified issue with logic for mesh peering (similar to Feature Request: Deploy private dns zones and link them to an existing vnet #549)
  5. Removes sensitive value filtering as per discussion to close Bug Report Terraform plan fails due to sensitive values in azurerm_automation_account output #499

Breaking Changes

None

Testing Evidence

Please refer to the updated test framework results, and additional evidence provided in the following issues:

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Updated the "RELEASE" page with details needed for when this code change is released.

@krowlandson krowlandson added bug Something isn't working enhancement New feature or request labels Dec 14, 2022
@krowlandson krowlandson added this to the v3.1.0 milestone Dec 14, 2022
@krowlandson krowlandson self-assigned this Dec 14, 2022
@krowlandson krowlandson changed the title Add new DNS capabilities Add new connectivity capabilities Dec 16, 2022
@krowlandson
Copy link
Contributor Author

/azp run update

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krowlandson krowlandson marked this pull request as ready for review December 16, 2022 10:40
@krowlandson
Copy link
Contributor Author

/azp run unit

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krowlandson
Copy link
Contributor Author

/azp run update

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krowlandson krowlandson merged commit 5203049 into Azure:main Dec 16, 2022
@krowlandson krowlandson deleted the patch/dns-variables branch December 16, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment