Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Kubernetes namespace for Arc DNS #529

Merged
merged 3 commits into from
Nov 29, 2022
Merged

Add Kubernetes namespace for Arc DNS #529

merged 3 commits into from
Nov 29, 2022

Conversation

krowlandson
Copy link
Contributor

Overview/Summary

This PR adds a missing privatelink.kubernetesconfiguration.azure.com namespace to the private DNS zones for Azure Arc.

This PR fixes/adds/changes/removes

  1. Missed in the fix for Review and update private DNS zones for private endpoint #482

Breaking Changes

None

Testing Evidence

See unit tests

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Updated the "RELEASE" page with details needed for when this code change is released.

@krowlandson
Copy link
Contributor Author

/azp run update

@krowlandson krowlandson self-assigned this Nov 29, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krowlandson krowlandson added the bug Something isn't working label Nov 29, 2022
@krowlandson krowlandson added this to the v3.1.0 milestone Nov 29, 2022
@krowlandson
Copy link
Contributor Author

/azp run update

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krowlandson
Copy link
Contributor Author

/azp run unit

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krowlandson krowlandson merged commit 353aaeb into Azure:main Nov 29, 2022
@krowlandson krowlandson deleted the patch-dns-for-arc branch November 29, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtracey93 jtracey93 jtracey93 approved these changes

Assignees

@krowlandson krowlandson

Labels
bug Something isn't working
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@krowlandson @jtracey93