Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old Data API builder version used #806

Closed
itpropro opened this issue Mar 4, 2024 · 7 comments
Closed

Old Data API builder version used #806

itpropro opened this issue Mar 4, 2024 · 7 comments

Comments

@itpropro
Copy link

itpropro commented Mar 4, 2024

The current implementation for the Data API builders seems to pull the latest version specified by this metadata url: https://go.microsoft.com/fwlink/?linkid=2226493.
This points to 0.9.7, not to the latest version 0.10.23 of the Data API builder.
I think the CLI should resolve the latest version based on the GitHub releases url (https://github.com/Azure/data-api-builder/releases/latest) that points to the latest release instead of relying on an internal link shortener/redirection service like go.microsoft.com.

@cjk7989
Copy link
Contributor

cjk7989 commented Mar 11, 2024

Thanks for reporting that. WIll update the link and your advise is very helpful.

@itpropro
Copy link
Author

Thanks for reporting that. WIll update the link and your advise is very helpful.

Any updates on this? As there are so many bugs in the old version, I have to manually overwrite 0.9.7 currently to make it work on most projects.

@MrMossevig
Copy link

@itpropro We have the same issues - how do you “overwrite” the version number?

@itpropro
Copy link
Author

Nice to see you taking over @Timothyw0 ! Would be great if you could look into this issue as well as #791 and #756.
Great to see the cli getting some love again, looking forward to support with PRs :)

@Timothyw0
Copy link
Member

Hi All, the internal Data API Builder team has reached out to us to update the metadata URL link to point to v1.1.7 of the API to be consistent with other applications. This should resolve the issue moving forward so I will be closing this issue.

@MrMossevig For future reference, if you would like to overwrite the DAB API version, you can edit the DATA_API_BUILDER_RELEASE_METADATA_URL in src/core/constants.ts to the dab-manifest.json of the version you are interested in. You can find the json's URL in the Data API Builder GitHub releases: https://github.com/Azure/data-api-builder/releases/tag/v1.1.7

Please feel free to re-open the issue or raise a new one if any issue still persists!

@MrMossevig
Copy link

Thank you @Timothyw0 !

Did you solve the issue in a future proof manner, so there is some transparency as to when new versions of the api will be propagated to SWA? Or will it continue to be updated on an ad-hoc basis?

@Timothyw0
Copy link
Member

@MrMossevig Unfortunately the link forwarding of our DAB Release Metadata URL is managed by another internal team so that is done at an ad-hoc basis. We are being asked to stay on the same version other SWA components are currently using.

If there ever is a blocker like this again, the workaround would be to overwrite that Metadata URL until all of SWA gets the green light to update to a newer DAB API version. Hope this helps! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants