-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mellanox] add document for thermal control related cli #832
[Mellanox] add document for thermal control related cli #832
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a section of the thermal control with some high level description of the way it should be managed and what are the files should be provided / edited? I think we should have a feature description as well as expected behaviour when feature is enabled/disabled and not just to commands itself.
Can you please add such section?
then i think the show commands which are relevant to that feature should be below the high level feature description
Hi @liat-grozovik , I discussed with @keboliu about provide a high level description about thermal policy management. And we agreed to add that section in thermal control design document because the cli document only contains description about command line. You can see it here Junchao-Mellanox/SONiC#2. What's your suggestion? |
retest this please |
1 similar comment
retest this please |
* [Mellanox] add document for thermal control related cli * Update review comments thermal zones -> thermal sensors * Make example better
* [Mellanox] add document for thermal control related cli * Update review comments thermal zones -> thermal sensors * Make example better
Make sure db_migrator is run after all config are loaded during (sonic-net#926) Vnet alias mapping (sonic-net#924) Changes to make lldp show command for multi-npu platforms. (sonic-net#914) [Mellanox] Fix thermal control issue: use natural sort for fan status and thermal status (sonic-net#836) [Mellanox] add document for thermal control related cli (sonic-net#832)
- What I did
- How I did it
- How to verify it
Verify it by preview the markdown document.
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)