-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[config] Add commands for adding/removing syslog servers #609
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tsvanduyn: Can you please also update the Command Reference Guide (https://github.com/Azure/sonic-utilities/blob/master/doc/Command-Reference.md) to add these commands in this PR? I forgot to ask this of you with your previous DHCCP Relay destination change. I would like you to open a separate PR to add those commands later, also.
Retest this please |
# | ||
@config.group() | ||
@click.pass_context | ||
def syslog(ctx): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jleveque @tsvanduyn
It seems that the function name "syslog" conflicts with the module "syslog", causing functions calling logxxx failed, like "config load_minigraph".
Is it possible to rename it, like "logserver"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stephenxs / @jleveque the ticket: #635
- What I did
I've added config commands to add/del syslog servers from the device.
- How I did it
- How to verify it
- Previous command output (if the output of a command-line utility has changed)
There was no previous command to add or remove syslog servers.
- New command output (if the output of a command-line utility has changed)
-->