Reduce time taken by show commands on multi-asic platforms #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhishek Dosi <[email protected]>
commands on multi-asic platforms. Signed-off-by: Abhishek Dosi <[email protected]>
rlhui
approved these changes
Apr 3, 2021
arlakshm
approved these changes
Apr 3, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
need #1541 |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
abdosi
added a commit
that referenced
this pull request
Apr 4, 2021
Optimize/Reduce the time taken by show interface * and show ip bgp * commands on Multi-asic platforms.
yxieca
pushed a commit
that referenced
this pull request
Apr 8, 2021
Optimize/Reduce the time taken by show interface * and show ip bgp * commands on Multi-asic platforms.
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
ad9022e (HEAD -> 201911, origin/201911) Reduce time taken by show commands on multi-asic platforms (sonic-net#1544) 4993a36 [fast-reboot]: Fix fail to execute fast-reboot problem (sonic-net#1047) Signed-off-by: Abhishek Dosi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
Optimize/Reduce the time taken by
show interface *andshow ip bgp *commands on Multi-asic platforms.How I did:
When checking for whether given port/port-channel/bgp-session is internal we used to walk through all namespace and collect data from each of then and then filter out.
Now as part of this PR we pass the namespace where port/port-channel/bgp-session belongs and then filter them out thus reducing the time considerably.
How I verify: