Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

be able to install latest v2 or latest v3 #12

Closed
davidkarlsen opened this issue May 9, 2020 · 7 comments
Closed

be able to install latest v2 or latest v3 #12

davidkarlsen opened this issue May 9, 2020 · 7 comments
Assignees
Labels
enhancement Feature request/improved experience

Comments

@davidkarlsen
Copy link

the 'latest' will pick whatever helm release was done last, either it's v2 or v3. It would be useful to define version as "latest v2" or "latest v3".

@shigupt202
Copy link
Contributor

@davidkarlsen Thanks for the feedback. I've raised a PR to fix this, so that the action downloads latest version and not the last updated version of Helm release.

@shigupt202 shigupt202 self-assigned this May 11, 2020
@thesattiraju
Copy link
Contributor

@shigupt202 I believe this is a different ask, in parallel to your fix.

@thesattiraju thesattiraju added the enhancement Feature request/improved experience label May 18, 2020
@anraghun
Copy link

anraghun commented Jun 4, 2020

@DS-MS We can have a delimiter separated input for the major version if latest is supplied as version such as latest;3 or latest:2. The logic can be modified to see if version.toLocaleLowerCase() contains "latest" and then probe for the additional major version.

@thesattiraju
Copy link
Contributor

@anraghun as discussed offline, we'll go ahead with 2.* and 3.* for getting the latest major version change.

@shigupt202 do you want to pick up this change?

@shigupt202
Copy link
Contributor

Sure

@thesattiraju
Copy link
Contributor

@shigupt202 any updates on this?

@shigupt202
Copy link
Contributor

shigupt202 commented Mar 31, 2021

This feature has been released in v1.1 (you'll need to specify this version with setup-helm in your workflow). Latest Helm 3 versions can be specified using 3.* and Helm 2 versions using 2.*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request/improved experience
Projects
None yet
Development

No branches or pull requests

4 participants