Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ISO-8859-1 for WebSocket upgrade request #43

Open
2 tasks
conniey opened this issue May 13, 2021 · 1 comment
Open
2 tasks

Use ISO-8859-1 for WebSocket upgrade request #43

conniey opened this issue May 13, 2021 · 1 comment
Labels
good first issue Good for newcomers up-for-grabs

Comments

@conniey
Copy link
Member

conniey commented May 13, 2021 •
edited
Loading

We use request.getBytes() to get the bytes for the upgrade request.

  • Add method in WebSocketHandler.createUpgradeRequest to return bytes[] rather than a String
    • I believe the createUpgradeRequest is already shipped, so we don't want to break existing users.
    • Encode bytes[] as ISO-8859-1
  • Remove spotbugs suppression:
@conniey conniey mentioned this issue May 13, 2021
Merged
@shreelakshmijoshi
Copy link

Hi @conniey !
I am a new open source contributor and would like to solve this issue, could you help me understand the issue better by providing some extra references ?
Is this is issue open to contribute ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers up-for-grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@conniey @shreelakshmijoshi