Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RequestBody parameter definition is lost when converting swagger 2.0 to 3.0 #83

Closed
leni-msft opened this issue Jan 10, 2020 · 5 comments
Assignees
Labels
P1 - Required Required functionality - not blocking

Comments

@leni-msft
Copy link

For request body parameters defined in a common place only for reference, it's lost when converting to 3.0.
https://github.com/Azure/perks/blob/master/oai2-to-oai3/main.ts#L204

visitParameterDefinitions(parameters: Iterable<Node>) {
    for (const { key, value, pointer, childIterator } of parameters) {
      if (value.in !== 'formData' && value.in !== 'body' && value.type !== 'file') {
@leni-msft
Copy link
Author

Hi @fearthecowboy, is there any update?

@daviwil daviwil added the P1 - Required Required functionality - not blocking label Jul 17, 2020
@timotheeguerin
Copy link
Member

@leni-msft Could you reclarify what is the problem here? Do you have a repro in particular?

Would this happen to be the same issue that was fixed here #131

@timotheeguerin timotheeguerin self-assigned this Dec 15, 2020
@leni-msft
Copy link
Author

@timotheeguerin
Copy link
Member

@leni-msft I believe this is the same issue that I fixed. Could you check it is still happening Azure/autorest#3546 (comment)

@leni-msft
Copy link
Author

@timotheeguerin Great! The issue is gone. Thanks very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 - Required Required functionality - not blocking
Projects
None yet
Development

No branches or pull requests

3 participants