Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate test pipelines to GH actions #330

Closed
mikeharder opened this issue May 23, 2024 · 2 comments · Fixed by #339
Closed

Migrate test pipelines to GH actions #330

mikeharder opened this issue May 23, 2024 · 2 comments · Fixed by #339
Assignees

Comments

@mikeharder
Copy link
Member

No description provided.

@konrad-jamrozik
Copy link

konrad-jamrozik commented Jul 2, 2024

@mikeharder so I merged this:

And here is an example run:

Now, ignoring the warnings about deprecated action versions for a moment.

Per @scbedd, package publication to public package manager must go through official 1ES templates. In this repo this happens via Azure DevOps pipeline, which depends on building as seen here:

Hence now that we have GitHub action also building and testing, we have duplication. To deduplicate we would have to ensure that the drop from GitHub action is taken as input by the ADO pipeline doing the publishing. I think it reads the drop in these lines:

Do you have any experience with reading from ADO pipeline a drop made by GitHub actions?

I think it would be worthwhile for us to figure this out, otherwise we would have to maintain build ADO pipeline for all our tools that publish to public package manager.

Did what I wrote make sense?

@konrad-jamrozik konrad-jamrozik self-assigned this Jul 2, 2024
@konrad-jamrozik
Copy link

Per my chat with @mikeharder:

  • For publishing packages, we must retain entire supply chain on 1ES agents. Perhaps there exists a GH actions based solution, but for now we are using the ADO pipelines-based solution.
  • We still want to retain GH actions but only for rapid building and testing. The ADO pipeline is used only for publishing new package version. Hence I will remove everything after test task from the GH action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Status: 🎊 Closed
Development

Successfully merging a pull request may close this issue.

2 participants