From 58ff9c16b8dae515b77613241943fb32707293c5 Mon Sep 17 00:00:00 2001 From: ChrisSidebotham-MSFT <48600046+ChrisSidebotham@users.noreply.github.com> Date: Tue, 13 Feb 2024 12:44:42 +0000 Subject: [PATCH 1/3] Updating PR Template --- .github/pull_request_template.md | 48 +++++++++++++++++++------------- 1 file changed, 28 insertions(+), 20 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 5d7a0cb627..2ccd2627a6 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,32 +1,40 @@ ## Description - + +Closes #123 +Closes #456 +--> -- [ ] A proposal has been submitted and approved. -- [ ] I have included "Closes #{module_proposal_issue_number}" in the PR description. -- [ ] I have run `brm validate` locally to verify the module files. -- [ ] I have run deployment tests locally to ensure the module is deployable. +## Pipeline Reference + -## Updating an existing module +| Pipeline | +| - | +| | - +## Type of Change -- [ ] This is a bug fix: + + +- [ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`. - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. -- [ ] I have run `brm validate` locally to verify the module files. -- [ ] I have run deployment tests locally to ensure the module is deployable. -- [ ] I have read the [Updating an existing module](https://github.com/Azure/bicep-registry-modules/blob/main/CONTRIBUTING.md#updating-an-existing-module) section in the contributing guide and updated the `version.json` file properly: - - [ ] The PR contains backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`. - - [ ] The PR contains backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - - [ ] The PR contains breaking changes, and I have bumped the MAJOR version in `version.json`. -- [ ] I have updated the examples in README with the latest module version number. +- [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. +- [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. +- [ ] Update to documentation + +## Checklist + +- [ ] I'm sure there are no other open Pull Requests for the same update/change +- [ ] I have run `Set-AVMModule` locally to generate the supporting module files. +- [ ] My corresponding pipelines / checks run clean and green without any errors or warnings From 7296c5663a7c8e7f5d42c190b72b07aa44a7b718 Mon Sep 17 00:00:00 2001 From: ChrisSidebotham-MSFT <48600046+ChrisSidebotham@users.noreply.github.com> Date: Tue, 13 Feb 2024 12:53:19 +0000 Subject: [PATCH 2/3] Update pull request template --- .github/pull_request_template.md | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 2ccd2627a6..5096bc4e06 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,16 +1,13 @@ ## Description @@ -26,15 +23,20 @@ Closes #456 -- [ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`. - - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. -- [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. -- [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. -- [ ] Update to documentation +- [ ] Update to CI Environment or utlities (Non-module effecting changes) +- [ ] Azure Verified Module updates: + - [ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: + - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. + - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. + - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. + - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. + - [ ] Update to documentation + ## Checklist - [ ] I'm sure there are no other open Pull Requests for the same update/change - [ ] I have run `Set-AVMModule` locally to generate the supporting module files. - [ ] My corresponding pipelines / checks run clean and green without any errors or warnings + + From 69b7a4210ca85b223e1582495e59110cbf87afe7 Mon Sep 17 00:00:00 2001 From: ChrisSidebotham-MSFT <48600046+ChrisSidebotham@users.noreply.github.com> Date: Tue, 20 Feb 2024 09:52:16 +0000 Subject: [PATCH 3/3] Update pull request template --- .github/pull_request_template.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 5096bc4e06..719d90a85f 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -13,11 +13,12 @@ Closes #456 --> ## Pipeline Reference + | Pipeline | -| - | -| | +| -------- | +| | ## Type of Change @@ -32,7 +33,6 @@ Closes #456 - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation - ## Checklist - [ ] I'm sure there are no other open Pull Requests for the same update/change