Fixed xattr reading and writing #2762
Conversation
tsvietOK
requested review from
gapra-msft,
adreed-msft,
dphulkar-msft,
vibhansa-msft,
seanmcc-msft,
souravgupta-msft and
tanyasethi-msft
as code owners
|
Seems like the test (from main branch, not from mine) on Linux is reporting not supported result: |
|
Tested my change: |
tsvietOK
force-pushed
the
fix-user-xattr
branch
from
42641d5
to
7b9a1b4
Compare
tsvietOK
force-pushed
the
fix-user-xattr
branch
from
7b9a1b4
to
7f65186
Compare
|
Maybe also there is needed some back compatibility mode (if user used old version of azcopy on Mac OS and file already has xattr without "user." prefix) for Mac OS where xattr works fine (according to test execution). |
tsvietOK
force-pushed
the
fix-user-xattr
branch
from
7f65186
to
c1897d7
Compare
There was a problem hiding this comment.
This is good, but it comes within a catch. This changes the metadata name, and somebody could have come to rely upon that. Two things need to happen to allow this through
- When reading, let's check for both.
- When writing, let's check that the "oldschool" version doesn't exist; if it does, delete it and replace it with the new attribute.
|
Seems like the requested changes are way above my knowledge of the Go. So, feel free to create a new PR or push to this one. By the way, wouldn't it be better to use this module https://github.com/pkg/xattr which covers support/error handling for some specific OSs like FreeBSD, NetBSD and MacOS? |
Fixes #2761
Based on https://stackoverflow.com/questions/60893372/why-must-a-user-be-prepended-to-the-name-when-setting-a-files-xattr-with-os and https://go.googlesource.com/sys.git/+/master/unix/xattr_bsd.go#31 looks like "user" prefix is needed when saving/reading xattr to/from the file.
I don't know the Go language, so feel free to add new changes to my branch or create a new one.