Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config map support for PrivateDnsZonesARecord #4326

Open
nraooptum opened this issue Oct 7, 2024 · 6 comments
Open

Add config map support for PrivateDnsZonesARecord #4326

nraooptum opened this issue Oct 7, 2024 · 6 comments
Assignees
Milestone

Comments

@nraooptum
Copy link

When we create a private endpoint, we're able to output the primaryNicPrivateIpAddress to a config map. However, PrivateDnsZonesARecord doesn't support config maps as input for the ipv4Address field.

@matthchr
Copy link
Member

@super-harsh is going to look into this, or if there is a better way to do this using the infrastructure that Azure provides (I thought there was a way to get this done automatically but need to look more).

@nraooptum
Copy link
Author

Perfect! Thank you both! In the interim, would the ipv4Address field be compatible with the $importConfigMapMode option?

@matthchr matthchr assigned matthchr and unassigned super-harsh Nov 4, 2024
@matthchr
Copy link
Member

I haven't had a chance to look into this further but just making a note we haven't forgotten.

@nraooptum
Copy link
Author

Thanks for the follow up Matt!

@nraooptum
Copy link
Author

@matthchr good news, our enterprise is adopting ASO as the way forward 👍 This passed our internal Architecture Review Board and everyone is excited to start migrating over to this.
 
Random side note, I was thinking, you know how we can export arbitrary values from a resource, e.g.:
https://azure.github.io/azure-service-operator/guide/configmaps/

Instead of having to implement $importConfigMapMode for a bunch of different things, what if we had the option of applying patches? For example (just making something up):

  operatorSpec:
    patchExpressions:
      - patchField: self.spec.aRecords[0].ipv4Address
        configMapName: some-configmap
        configMapKey: myIpV4Address

This would make it generic enough to pass stuff around even when the resource doesn't natively "support" injecting a value from a config map, especially when combined with the ability to export anything using configMapExpressions.

@nraooptum
Copy link
Author

Hi, since none of our resources are internet facing (needs private endpoints), it's causing some of our developers issues as we more broadly expand this in our org, as users can create PEs but can't associate those IPs in our private DNS zones. Happy to try and contribute a PR for the config map support over the holiday break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants