This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 52
Only retry with retryable amqp errors for sender #201
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinfish
force-pushed
the
sender-retry
branch
from
December 22, 2020 02:49
c55bbc8
to
68afb67
Compare
catalinaperalta
previously approved these changes
Dec 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
catalinaperalta
dismissed
their stale review
December 22, 2020 22:58
Need to update changelog and add method comment.
Could you also add a test to mock receiving these errors and also update the changelog? I'll then approve again. |
gavinfish
force-pushed
the
sender-retry
branch
2 times, most recently
from
December 24, 2020 15:14
57eca53
to
9a836ff
Compare
@catalinaperalta I have some problems to add unit tests here. As |
catalinaperalta
approved these changes
Jan 5, 2021
jhendrixMSFT
suggested changes
Jan 8, 2021
gavinfish
force-pushed
the
sender-retry
branch
from
January 11, 2021 12:57
9a836ff
to
9d82129
Compare
jhendrixMSFT
approved these changes
Jan 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #200
You can refer to python sdk with similar logic at
https://github.com/Azure/azure-sdk-for-python/blob/c9240aa68c2870a1a72249b4c86f3ca95551cc29/sdk/servicebus/azure-servicebus/azure/servicebus/exceptions.py#L58-L80
com.microsoft:server-busy
with 10s delay which is suggested from service bus error.