This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Add AzureEnvironment namespace option and use its definition #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serbrech
force-pushed
the
ster/fix-env
branch
from
d6bb4f1 to
16f268a
Compare
serbrech
commented
Sep 28, 2020
serbrech
commented
Sep 29, 2020
serbrech
commented
Sep 29, 2020
serbrech
commented
Sep 29, 2020
serbrech
commented
Sep 29, 2020
jhendrixMSFT
approved these changes
Dec 1, 2020
|
Fix is in v0.10.7 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The namespace connection settings are currently harcoded.
when deployed in different azure environment, Suffix and authentidation resourceURI endpoint need to be configured.
For most cases the autorest environment configuration should work, and should be the default source of truth.
For some special cases, we need to configure it manually.
This allows to use the values set in autorest azure environments, and to override it alltogether if needed by exposing the ResourceURI properties on the Namespace struct.
I think that the autorest environment value for service bus is outdated, and I have opened an issue for it :
Azure/go-autorest#565