Skip to content

Conversation

@scbedd
Copy link
Member

@scbedd scbedd commented Jun 17, 2024

The following yml are associated with projects that need to publish to npmjs.org. This PR simply removes each's individual release stage in favor of a single added stage. After walking each package within azure-sdk-tools, I believe these are the only remaining builds that must become 1es compliant.

  • tools/sdk-generation-pipeline/ci.yml Deleted in main
  • tools/oav-traffic-converter/ci.yml
  • tools/mock-service-host/ci.yml
  • tools/js-sdk-release-tools/ci.yml
  • tools/apiview/parsers/js-api-parser/ci.yml Only publishes to internal feed
  • tools/apiview/emitters/typespec-apiview/ci.yml -- this only needs ESRP Release stage, already 1es compliant.
  • eng/pipelines/templates/stages/archetype-autorest-preview.yml This yml is referenced nowhere that I can tell. Not from another template and not direct from a build definition.
  • tools/tsp-client/ci.yml -- this only needs ESRP Release stage, already 1es

FOR REVIEWERS I advise disabling whitespace diffs it massively simplifies looking at what this PR does. Much more re-use than code deletion.

Related to #7941

@scbedd scbedd changed the title Convert remaining packages which necessitate 1es-templates Convert remaining packages which necessitate 1es-templates/esrp release Jun 17, 2024
@scbedd scbedd self-assigned this Jun 17, 2024
@scbedd scbedd marked this pull request as ready for review June 17, 2024 22:02
@scbedd
Copy link
Member Author

scbedd commented Jun 17, 2024

/check-enforcer override

The tsp-client failure is merely because I cancelled the release itself.

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable assuming test pipelines work.

@MaryGao MaryGao requested a review from wanlwanl June 20, 2024 03:49
@weshaggard
Copy link
Member

Ray recently deleted tools/sdk-generation-pipeline/ci.yml so you can remove those changes.

@scbedd
Copy link
Member Author

scbedd commented Jun 20, 2024

Will do so. Needed to get in here to make the SemVer changes anyway.

@scbedd
Copy link
Member Author

scbedd commented Jun 20, 2024

My claim is that

  1. The existing build failures are already existing. Going to ignore them.
  2. For the failed SDL Sources, I believe this is only on the merge PR causing some weird interaction with the submodules. This doesn't occur when just run straight from the branch. And the branch is updated from main as of this morning.

Just going to merge this and then deal with the fallout.

@scbedd
Copy link
Member Author

scbedd commented Jun 20, 2024

/check-enforcer overrde

@github-actions
Copy link

For help using check enforcer, see https://aka.ms/azsdk/checkenforcer

Available commands:

  • /check-enforcer evaluate - Re-evaluate existing pipeline statuses for PR
  • /check-enforcer override - Ignore any pipeline missing or failed statuses for PR
  • /check-enforcer help - Add this comment

If you are initializing a new service, follow the new service docs. If no Azure Pipelines are desired, run /check-enforcer override.

@scbedd scbedd merged commit 2f2b078 into main Jun 20, 2024
@scbedd scbedd deleted the add-node-release-template branch June 20, 2024 19:52

- task: PowerShell@2
inputs:
filePath: '$(Build.SourcesDirectory)/eng/scripts/determine-release-tag.ps1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file doesnt match the new one being added in the PR. Seems like the file name should be determine-js-release-tag.ps1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants