remove greedy suffix on link check #2617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danewalton-msft
requested review from
benbp,
sima-zhu and
weshaggard
as code owners
Collaborator
|
The following pipelines have been queued for testing: |
sima-zhu
approved these changes
Jan 26, 2022
Contributor
sima-zhu
left a comment
sima-zhu
left a comment
There was a problem hiding this comment.
Thanks for catching this!
Member
|
@danewalton thanks for the fix. @sima-zhu could you please take this PR through the sync process. |
RickWinter
approved these changes
Jan 26, 2022
This was referenced Jan 26, 2022
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally opened here: Azure/azure-sdk-for-c#2080
note conversation here: Azure/azure-sdk-for-c#2065 (comment)
The link verifier is lumping SDK urls with a suffix in with the root sdk. So "azure-sdk-for-c-arduino" is getting lumped in with "azure-sdk-for-c".