Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation doesn't properly reset when new commits are pushed to PRs approved to merge #7650

Open
konrad-jamrozik opened this issue Feb 7, 2024 · 0 comments
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.

Comments

@konrad-jamrozik
Copy link
Contributor

konrad-jamrozik commented Feb 7, 2024

When a PR to private repo main branch has been Ok-ApprovedToMerge, and a new commit gets pushed to the PR, the automation should do "hard reset" - all approval labels should be removed. They currently are not, so if the new commit pushed after approval has breaking changes or needs ARM review, it won't happen - the automation will see the approval labels and consider all automated checks as passing.

Relevant PR:
https://github.com/Azure/azure-rest-api-specs-pr/pull/16435

This problem may be also present on PRs to other branches too, like public main. This way people could circumvent the process. Albeit so far we haven't seen anyone managing to successfully bypass our checks like that yet.

For details see this Teams conversation for details.

Related (newer) issue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
Status: 📋 Backlog
Status: 📋 Backlog
Development

No branches or pull requests

1 participant