Automation doesn't properly reset when new commits are pushed to PRs approved to merge #7650
Labels
Central-EngSys
This issue is owned by the Engineering System team.
Spec PR Tools
Tooling that runs in azure-rest-api-specs repo.
When a PR to private repo main branch has been
Ok-ApprovedToMerge
, and a new commit gets pushed to the PR, the automation should do "hard reset" - all approval labels should be removed. They currently are not, so if the new commit pushed after approval has breaking changes or needs ARM review, it won't happen - the automation will see the approval labels and consider all automated checks as passing.Relevant PR:
https://github.com/Azure/azure-rest-api-specs-pr/pull/16435
This problem may be also present on PRs to other branches too, like public main. This way people could circumvent the process. Albeit so far we haven't seen anyone managing to successfully bypass our checks like that yet.
For details see this Teams conversation for details.
Related (newer) issue:
The text was updated successfully, but these errors were encountered: