Skip to content

Conversation

@swathipil
Copy link
Member

@swathipil swathipil commented Oct 18, 2024

Found during #38067.

  • Updating the CBS put token auth interaction to send a Disposition(...state="Accepted") after receiving one from the service. Otherwise, the service will re-send the original "Accepted" Disposition (in the middle of receiving messages).

  • Previous amqp stack does this and does not get the re-sent "Accepted" disposition from the service.

  • TODO:

    • async
    • tests
    • compare with Go frames

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

self._mgmt_link._response_link.send_disposition(
first_delivery_id=0,
last_delivery_id=0,
delivery_tag=b"$cbs", # CBS auth sends disposition back on put token 202, set fake delivery tag
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delivery tag for auth transfer frame?

@swathipil swathipil changed the title [ServiceBus] fix unexpected frame buffer offset error [ServiceBus] send disposition back on auth ok Oct 23, 2024
@github-actions
Copy link

Hi @swathipil. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Dec 27, 2024
@github-actions
Copy link

github-actions bot commented Jan 3, 2025

Hi @swathipil. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

@github-actions github-actions bot closed this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-recent-activity There has been no recent activity on this issue. Service Bus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants