[ServiceBus] update ValueError to AMQPConnectionError for closed connection #34786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
API change check API changes are not detected in this pull request. |
kashifkhan
reviewed
Mar 18, 2024
sdk/servicebus/azure-servicebus/azure/servicebus/_pyamqp/_transport.py
Outdated
Show resolved
Hide resolved
kashifkhan
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a connection is disconnected during send, it will not retry since the underlying error being raised is a
ValueErrorthen wrapped with ServiceBusError, which is not retryable. Updating this to an AMQPConnectionError with SocketError as the condition, since we want this to be caught and raised as a ServiceBusConnectionError, then retried.Did not add tests, since this was reproduced by turning off the connection (wifi) when sending, which cannot be done in our current test environment.
Stress was run over the weekend against this patch with no errors + sending/receiving equal number of messages.