Skip to content

Conversation

@scbedd
Copy link
Member

@scbedd scbedd commented May 3, 2023

The code being adjusted in this PR is used at the base of every tox environment that is testing the specifically built artifact from the previous stage. We want to test what we build, and this code is what ensures that.

Logic Before:

  • Search for all wheels that match package name and version
  • Find the whl that matches our major py version
  • Return that

Logic After:

  • Search for all wheels that match package name and version
  • Get list of compatible tags for our currently invoking interpreter, using pip
  • Walk the list of wheels for the package we want, checking each one against the set of compatible tags
  • On first compatible tag, return the wheel

This resolves #9613 and is a prerequisite for #28211

@scbedd scbedd requested review from benbp and weshaggard as code owners May 3, 2023 02:09
@scbedd scbedd requested a review from mccoyp May 3, 2023 02:13
@scbedd scbedd self-assigned this May 3, 2023
Copy link
Member

@mccoyp mccoyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits about .format, only one comment about what looks like a hanging variable

Copy link
Member

@mccoyp mccoyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the small things I commented on, LGTM

@scbedd scbedd merged commit b29b0db into Azure:main May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Whl discovery step is ignoring platform type when running test

2 participants