-
Notifications
You must be signed in to change notification settings - Fork 3.2k
"Find Wheel" now handles platform-specific artifacts during selection #30196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scbedd
commented
May 3, 2023
scbedd
commented
May 8, 2023
mccoyp
reviewed
May 12, 2023
Member
mccoyp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nits about .format, only one comment about what looks like a hanging variable
mccoyp
approved these changes
May 25, 2023
Member
mccoyp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the small things I commented on, LGTM
Co-authored-by: McCoy Patiño <[email protected]>
…t in build_temp_whl()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code being adjusted in this PR is used at the base of every
toxenvironment that is testing the specifically built artifact from the previous stage. We want to test what we build, and this code is what ensures that.Logic Before:
Logic After:
pipThis resolves #9613 and is a prerequisite for #28211