From 80018426e5ba82c7772c89af560d105f4ef5bc54 Mon Sep 17 00:00:00 2001 From: Mike Harder Date: Fri, 6 Jan 2023 16:43:36 -0800 Subject: [PATCH 1/6] Remove language from profile zip --- eng/common/pipelines/templates/jobs/perf.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/common/pipelines/templates/jobs/perf.yml b/eng/common/pipelines/templates/jobs/perf.yml index b19bd5c88bd4..b6a75436fa34 100644 --- a/eng/common/pipelines/templates/jobs/perf.yml +++ b/eng/common/pipelines/templates/jobs/perf.yml @@ -173,7 +173,7 @@ jobs: - task: PublishPipelineArtifact@1 inputs: - targetPath: $(System.DefaultWorkingDirectory)/${{ parameters.Language }}-profile.zip + targetPath: $(System.DefaultWorkingDirectory)/profile.zip artifactName: ${{ parameters.Language }}-profile.zip condition: ${{ parameters.Profile }} From 43c865e1f89de461c7a4abe16dcca08ed962275f Mon Sep 17 00:00:00 2001 From: Mike Harder Date: Fri, 6 Jan 2023 17:00:02 -0800 Subject: [PATCH 2/6] Revert "Remove language from profile zip" This reverts commit 2f670435b25f89955338170a7bdfbe4432cbe23f. --- eng/common/pipelines/templates/jobs/perf.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/common/pipelines/templates/jobs/perf.yml b/eng/common/pipelines/templates/jobs/perf.yml index b6a75436fa34..b19bd5c88bd4 100644 --- a/eng/common/pipelines/templates/jobs/perf.yml +++ b/eng/common/pipelines/templates/jobs/perf.yml @@ -173,7 +173,7 @@ jobs: - task: PublishPipelineArtifact@1 inputs: - targetPath: $(System.DefaultWorkingDirectory)/profile.zip + targetPath: $(System.DefaultWorkingDirectory)/${{ parameters.Language }}-profile.zip artifactName: ${{ parameters.Language }}-profile.zip condition: ${{ parameters.Profile }} From 29983d79d7aceaaa5cdf4c8c8bf97a55a9d01198 Mon Sep 17 00:00:00 2001 From: Mike Harder Date: Mon, 23 Jan 2023 23:00:20 -0800 Subject: [PATCH 3/6] Remove Services parameter --- eng/common/pipelines/templates/jobs/perf.yml | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/eng/common/pipelines/templates/jobs/perf.yml b/eng/common/pipelines/templates/jobs/perf.yml index b19bd5c88bd4..28d9a0bd2a2f 100644 --- a/eng/common/pipelines/templates/jobs/perf.yml +++ b/eng/common/pipelines/templates/jobs/perf.yml @@ -38,9 +38,6 @@ parameters: - name: ServiceDirectory type: string default: '' -- name: Services - type: string - default: '' - name: PackageVersions type: string default: '.*' @@ -118,17 +115,12 @@ jobs: Location: westus ResourceType: perf - - pwsh: | - set-content -path config.yml -value "WorkingDirectories:" - add-content -path config.yml -value " ${{ parameters.Language }}: $(Agent.BuildDirectory)/s" - workingDirectory: azure-sdk-tools/tools/perf-automation/Azure.Sdk.Tools.PerfAutomation - displayName: Create config.yml - - script: >- dotnet run -- run --no-sync - --languages ${{ parameters.Language }} - --services "${{ parameters.Services }}" + --language ${{ parameters.Language }} + --repo-root $(System.DefaultWorkingDirectory) + --tests-file $(System.DefaultWorkingDirectory)/${{ parameters.ServiceDirectory }}/perf-tests.yml --package-versions "${{ parameters.PackageVersions }}" --tests "${{ parameters.Tests }}" --arguments "${{ parameters.Arguments }}" From 2c9a014e8accc0abbeb3bbd12f515c5867efeb1d Mon Sep 17 00:00:00 2001 From: Mike Harder Date: Mon, 23 Jan 2023 23:23:30 -0800 Subject: [PATCH 4/6] Fix path to tests-file --- eng/common/pipelines/templates/jobs/perf.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/common/pipelines/templates/jobs/perf.yml b/eng/common/pipelines/templates/jobs/perf.yml index 28d9a0bd2a2f..671e6f0d3ac5 100644 --- a/eng/common/pipelines/templates/jobs/perf.yml +++ b/eng/common/pipelines/templates/jobs/perf.yml @@ -120,7 +120,7 @@ jobs: --no-sync --language ${{ parameters.Language }} --repo-root $(System.DefaultWorkingDirectory) - --tests-file $(System.DefaultWorkingDirectory)/${{ parameters.ServiceDirectory }}/perf-tests.yml + --tests-file $(System.DefaultWorkingDirectory)/sdk/${{ parameters.ServiceDirectory }}/perf-tests.yml --package-versions "${{ parameters.PackageVersions }}" --tests "${{ parameters.Tests }}" --arguments "${{ parameters.Arguments }}" From a84d752293d9909f6c14473b322db09e06fb5ffb Mon Sep 17 00:00:00 2001 From: Mike Harder Date: Thu, 26 Jan 2023 22:19:28 -0800 Subject: [PATCH 5/6] Run both sync and async tests by default --- eng/common/pipelines/templates/jobs/perf.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/eng/common/pipelines/templates/jobs/perf.yml b/eng/common/pipelines/templates/jobs/perf.yml index 671e6f0d3ac5..3d52542ad9ac 100644 --- a/eng/common/pipelines/templates/jobs/perf.yml +++ b/eng/common/pipelines/templates/jobs/perf.yml @@ -117,7 +117,6 @@ jobs: - script: >- dotnet run -- run - --no-sync --language ${{ parameters.Language }} --repo-root $(System.DefaultWorkingDirectory) --tests-file $(System.DefaultWorkingDirectory)/sdk/${{ parameters.ServiceDirectory }}/perf-tests.yml From 734ba29ba8895828b3766f9c96ae30d0cced922c Mon Sep 17 00:00:00 2001 From: Mike Harder Date: Tue, 31 Jan 2023 14:24:19 -0800 Subject: [PATCH 6/6] Add LanguageVersion to common perf.yml --- eng/common/pipelines/templates/jobs/perf.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/eng/common/pipelines/templates/jobs/perf.yml b/eng/common/pipelines/templates/jobs/perf.yml index 3d52542ad9ac..ff2d53162558 100644 --- a/eng/common/pipelines/templates/jobs/perf.yml +++ b/eng/common/pipelines/templates/jobs/perf.yml @@ -17,6 +17,9 @@ parameters: - name: Language type: string default: '' +- name: LanguageVersion + type: string + default: '' - name: LanguageRepoName type: string default: $(Build.Repository.Name) @@ -118,6 +121,7 @@ jobs: - script: >- dotnet run -- run --language ${{ parameters.Language }} + --language-version ${{ parameters.LanguageVersion }} --repo-root $(System.DefaultWorkingDirectory) --tests-file $(System.DefaultWorkingDirectory)/sdk/${{ parameters.ServiceDirectory }}/perf-tests.yml --package-versions "${{ parameters.PackageVersions }}"