diff --git a/sdk/keyvault/azure-keyvault-certificates/tests/test_certificates_client.py b/sdk/keyvault/azure-keyvault-certificates/tests/test_certificates_client.py index 07a5201ecf78..7b74697e7b94 100644 --- a/sdk/keyvault/azure-keyvault-certificates/tests/test_certificates_client.py +++ b/sdk/keyvault/azure-keyvault-certificates/tests/test_certificates_client.py @@ -596,16 +596,20 @@ def test_logging_enabled(self, client, **kwargs): for message in mock_handler.messages: if message.levelname == "DEBUG" and message.funcName == "on_request": - messages_request = message.message.split("/n") - for m in messages_request: + # parts of the request are logged on new lines in a single message + request_sections = message.message.split("/n") + for section in request_sections: try: - body = json.loads(m) + # the body of the request should be JSON + body = json.loads(section) if body["provider"] == "Test": + mock_handler.close() return except (ValueError, KeyError): - # this means the message is not JSON or has no kty property + # this means the request section is not JSON pass + mock_handler.close() assert False, "Expected request body wasn't logged" @logging_disabled() @@ -622,15 +626,21 @@ def test_logging_disabled(self, client, **kwargs): for message in mock_handler.messages: if message.levelname == "DEBUG" and message.funcName == "on_request": - messages_request = message.message.split("/n") - for m in messages_request: + # parts of the request are logged on new lines in a single message + request_sections = message.message.split("/n") + for section in request_sections: try: - body = json.loads(m) - assert body["provider"] != "Test", "Client request body was logged" + # the body of the request should be JSON + body = json.loads(section) + if body["provider"] == "Test": + mock_handler.close() + assert False, "Client request body was logged" except (ValueError, KeyError): - # this means the message is not JSON or has no kty property + # this means the request section is not JSON pass + mock_handler.close() + @only_2016_10_01() @client_setup def test_models(self, client, **kwargs): diff --git a/sdk/keyvault/azure-keyvault-certificates/tests/test_certificates_client_async.py b/sdk/keyvault/azure-keyvault-certificates/tests/test_certificates_client_async.py index beb97d41b629..15079d19663e 100644 --- a/sdk/keyvault/azure-keyvault-certificates/tests/test_certificates_client_async.py +++ b/sdk/keyvault/azure-keyvault-certificates/tests/test_certificates_client_async.py @@ -602,16 +602,20 @@ async def test_logging_enabled(self, client, **kwargs): for message in mock_handler.messages: if message.levelname == "DEBUG" and message.funcName == "on_request": - messages_request = message.message.split("/n") - for m in messages_request: + # parts of the request are logged on new lines in a single message + request_sections = message.message.split("/n") + for section in request_sections: try: - body = json.loads(m) + # the body of the request should be JSON + body = json.loads(section) if body["provider"] == "Test": + mock_handler.close() return except (ValueError, KeyError): - # this means the message is not JSON or has no kty property + # this means the request section is not JSON pass + mock_handler.close() assert False, "Expected request body wasn't logged" @logging_disabled() @@ -628,15 +632,21 @@ async def test_logging_disabled(self, client, **kwargs): for message in mock_handler.messages: if message.levelname == "DEBUG" and message.funcName == "on_request": - messages_request = message.message.split("/n") - for m in messages_request: + # parts of the request are logged on new lines in a single message + request_sections = message.message.split("/n") + for section in request_sections: try: - body = json.loads(m) - assert body["provider"] != "Test", "Client request body was logged" + # the body of the request should be JSON + body = json.loads(section) + if body["provider"] == "Test": + mock_handler.close() + assert False, "Client request body was logged" except (ValueError, KeyError): - # this means the message is not JSON or has no kty property + # this means the request section is not JSON pass + mock_handler.close() + @all_api_versions() @client_setup async def test_get_certificate_version(self, client, **kwargs): diff --git a/sdk/keyvault/azure-keyvault-keys/tests/test_key_client.py b/sdk/keyvault/azure-keyvault-keys/tests/test_key_client.py index 315235049869..95a75d234cc2 100644 --- a/sdk/keyvault/azure-keyvault-keys/tests/test_key_client.py +++ b/sdk/keyvault/azure-keyvault-keys/tests/test_key_client.py @@ -426,17 +426,21 @@ def test_logging_enabled(self, client, is_hsm, **kwargs): for message in mock_handler.messages: if message.levelname == "DEBUG" and message.funcName == "on_request": - messages_request = message.message.split("/n") - for m in messages_request: + # parts of the request are logged on new lines in a single message + request_sections = message.message.split("/n") + for section in request_sections: try: - body = json.loads(m) + # the body of the request should be JSON + body = json.loads(section) expected_kty = "RSA-HSM" if is_hsm else "RSA" if body["kty"] == expected_kty: + mock_handler.close() return except (ValueError, KeyError): - # this means the message is not JSON or has no kty property + # this means the request section is not JSON or has no kty property pass + mock_handler.close() assert False, "Expected request body wasn't logged" @logging_disabled() @@ -453,16 +457,22 @@ def test_logging_disabled(self, client, is_hsm, **kwargs): for message in mock_handler.messages: if message.levelname == "DEBUG" and message.funcName == "on_request": - messages_request = message.message.split("/n") - for m in messages_request: + # parts of the request are logged on new lines in a single message + request_sections = message.message.split("/n") + for section in request_sections: try: - body = json.loads(m) + # the body of the request should be JSON + body = json.loads(section) expected_kty = "RSA-HSM" if is_hsm else "RSA" - assert body["kty"] != expected_kty, "Client request body was logged" + if body["kty"] == expected_kty: + mock_handler.close() + assert False, "Client request body was logged" except (ValueError, KeyError): - # this means the message is not JSON or has no kty property + # this means the request section is not JSON or has no kty property pass + mock_handler.close() + @only_hsm_7_3_preview() @client_setup def test_get_random_bytes(self, client, **kwargs): diff --git a/sdk/keyvault/azure-keyvault-keys/tests/test_keys_async.py b/sdk/keyvault/azure-keyvault-keys/tests/test_keys_async.py index 7efd0e28f9c0..b95bcff0f0f4 100644 --- a/sdk/keyvault/azure-keyvault-keys/tests/test_keys_async.py +++ b/sdk/keyvault/azure-keyvault-keys/tests/test_keys_async.py @@ -423,17 +423,21 @@ async def test_logging_enabled(self, client, is_hsm, **kwargs): for message in mock_handler.messages: if message.levelname == "DEBUG" and message.funcName == "on_request": - messages_request = message.message.split("/n") - for m in messages_request: + # parts of the request are logged on new lines in a single message + request_sections = message.message.split("/n") + for section in request_sections: try: - body = json.loads(m) + # the body of the request should be JSON + body = json.loads(section) expected_kty = "RSA-HSM" if is_hsm else "RSA" if body["kty"] == expected_kty: + mock_handler.close() return except (ValueError, KeyError): - # this means the message is not JSON or has no kty property + # this means the request section is not JSON or has no kty property pass + mock_handler.close() assert False, "Expected request body wasn't logged" @logging_disabled() @@ -450,16 +454,22 @@ async def test_logging_disabled(self, client, is_hsm, **kwargs): for message in mock_handler.messages: if message.levelname == "DEBUG" and message.funcName == "on_request": - messages_request = message.message.split("/n") - for m in messages_request: + # parts of the request are logged on new lines in a single message + request_sections = message.message.split("/n") + for section in request_sections: try: - body = json.loads(m) + # the body of the request should be JSON + body = json.loads(section) expected_kty = "RSA-HSM" if is_hsm else "RSA" - assert body["kty"] != expected_kty, "Client request body was logged" + if body["kty"] == expected_kty: + mock_handler.close() + assert False, "Client request body was logged" except (ValueError, KeyError): - # this means the message is not JSON or has no kty property + # this means the request section is not JSON or has no kty property pass + mock_handler.close() + @only_hsm_7_3_preview() @client_setup async def test_get_random_bytes(self, client, **kwargs): diff --git a/sdk/keyvault/azure-keyvault-secrets/tests/test_secrets_async.py b/sdk/keyvault/azure-keyvault-secrets/tests/test_secrets_async.py index ccd5828f3f84..2cc178f214f6 100644 --- a/sdk/keyvault/azure-keyvault-secrets/tests/test_secrets_async.py +++ b/sdk/keyvault/azure-keyvault-secrets/tests/test_secrets_async.py @@ -291,16 +291,20 @@ async def test_logging_enabled(self, client, **kwargs): for message in mock_handler.messages: if message.levelname == "DEBUG" and message.funcName == "on_request": - messages_request = message.message.split("/n") - for m in messages_request: + # parts of the request are logged on new lines in a single message + request_sections = message.message.split("/n") + for section in request_sections: try: - body = json.loads(m) + # the body of the request should be JSON + body = json.loads(section) if body["value"] == "secret-value": + mock_handler.close() return except (ValueError, KeyError): - # this means the message is not JSON or has no kty property + # this means the request section is not JSON pass + mock_handler.close() assert False, "Expected request body wasn't logged" @logging_disabled() @@ -317,15 +321,21 @@ async def test_logging_disabled(self, client, **kwargs): for message in mock_handler.messages: if message.levelname == "DEBUG" and message.funcName == "on_request": - messages_request = message.message.split("/n") - for m in messages_request: + # parts of the request are logged on new lines in a single message + request_sections = message.message.split("/n") + for section in request_sections: try: - body = json.loads(m) - assert body["value"] != "secret-value", "Client request body was logged" + # the body of the request should be JSON + body = json.loads(section) + if body["value"] == "secret-value": + mock_handler.close() + assert False, "Client request body was logged" except (ValueError, KeyError): # this means the message is not JSON or has no kty property pass + mock_handler.close() + def test_service_headers_allowed_in_logs(): service_headers = {"x-ms-keyvault-network-info", "x-ms-keyvault-region", "x-ms-keyvault-service-version"} diff --git a/sdk/keyvault/azure-keyvault-secrets/tests/test_secrets_client.py b/sdk/keyvault/azure-keyvault-secrets/tests/test_secrets_client.py index 893ac113e5cd..d2beca9462b8 100644 --- a/sdk/keyvault/azure-keyvault-secrets/tests/test_secrets_client.py +++ b/sdk/keyvault/azure-keyvault-secrets/tests/test_secrets_client.py @@ -297,16 +297,20 @@ def test_logging_enabled(self, client, **kwargs): for message in mock_handler.messages: if message.levelname == "DEBUG" and message.funcName == "on_request": - messages_request = message.message.split("/n") - for m in messages_request: + # parts of the request are logged on new lines in a single message + request_sections = message.message.split("/n") + for section in request_sections: try: - body = json.loads(m) + # the body of the request should be JSON + body = json.loads(section) if body["value"] == "secret-value": + mock_handler.close() return except (ValueError, KeyError): - # this means the message is not JSON or has no kty property + # this means the request section is not JSON pass + mock_handler.close() assert False, "Expected request body wasn't logged" @logging_disabled() @@ -323,15 +327,21 @@ def test_logging_disabled(self, client, **kwargs): for message in mock_handler.messages: if message.levelname == "DEBUG" and message.funcName == "on_request": - messages_request = message.message.split("/n") - for m in messages_request: + # parts of the request are logged on new lines in a single message + request_sections = message.message.split("/n") + for section in request_sections: try: - body = json.loads(m) - assert body["value"] != "secret-value", "Client request body was logged" + # the body of the request should be JSON + body = json.loads(section) + if body["value"] == "secret-value": + mock_handler.close() + assert False, "Client request body was logged" except (ValueError, KeyError): # this means the message is not JSON or has no kty property pass + mock_handler.close() + def test_service_headers_allowed_in_logs(): service_headers = {"x-ms-keyvault-network-info", "x-ms-keyvault-region", "x-ms-keyvault-service-version"}