Skip to content

[core] remove unnecessary awaits in async rest tests #21423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iscai-msft merged 1 commit into from
Oct 26, 2021
Merged

[core] remove unnecessary awaits in async rest tests #21423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions sdk/core/azure-core/tests/async_tests/test_rest_http_response_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ async def test_response_content_type_encoding(send_request):
response = await send_request(
request=HttpRequest("GET", "/encoding/latin-1")
)
await response.read()
assert response.content_type == "text/plain; charset=latin-1"
assert response.content == b'Latin 1: \xff'
assert response.text() == "Latin 1: ÿ"
Expand All @@ -122,7 +121,6 @@ async def test_response_autodetect_encoding(send_request):
response = await send_request(
request=HttpRequest("GET", "/encoding/latin-1")
)
await response.read()
assert response.text() == u'Latin 1: ÿ'
assert response.encoding == "latin-1"

Expand All @@ -135,7 +133,6 @@ async def test_response_fallback_to_autodetect(send_request):
response = await send_request(
request=HttpRequest("GET", "/encoding/invalid-codec-name")
)
await response.read()
assert response.headers["Content-Type"] == "text/plain; charset=invalid-codec-name"
assert response.text() == "おはようございます。"
assert response.encoding is None
Expand Down Expand Up @@ -168,7 +165,6 @@ async def test_response_no_charset_with_iso_8859_1_content(send_request):
response = await send_request(
request=HttpRequest("GET", "/encoding/iso-8859-1"),
)
await response.read()
assert response.text() == "Accented: �sterreich"
assert response.encoding is None

Expand All @@ -177,7 +173,6 @@ async def test_json(send_request):
response = await send_request(
request=HttpRequest("GET", "/basic/json"),
)
await response.read()
assert response.json() == {"greeting": "hello", "recipient": "world"}
assert response.encoding is None

Expand All @@ -186,7 +181,6 @@ async def test_json_with_specified_encoding(send_request):
response = await send_request(
request=HttpRequest("GET", "/encoding/json"),
)
await response.read()
assert response.json() == {"greeting": "hello", "recipient": "world"}
assert response.encoding == "utf-16"

Expand All @@ -195,23 +189,20 @@ async def test_emoji(send_request):
response = await send_request(
request=HttpRequest("GET", "/encoding/emoji"),
)
await response.read()
assert response.text() == "👩"

@pytest.mark.asyncio
async def test_emoji_family_with_skin_tone_modifier(send_request):
response = await send_request(
request=HttpRequest("GET", "/encoding/emoji-family-skin-tone-modifier"),
)
await response.read()
assert response.text() == "👩🏻‍👩🏽‍👧🏾‍👦🏿 SSN: 859-98-0987"

@pytest.mark.asyncio
async def test_korean_nfc(send_request):
response = await send_request(
request=HttpRequest("GET", "/encoding/korean"),
)
await response.read()
assert response.text() == "아가"

@pytest.mark.asyncio
Expand Down